Review main Merged

62429[TASK] Use ArrayObject for middleware storage in symfony container

Benjamin Franzke CR +2 V +2 Normal +45 −38 updated 11/29/19, 10:34

Commit message

Symfony 4.4 deprecated support for non-object services:
https://github.com/symfony/dependency-injection/commit/6f11b359ab9

The usage of `array` as service is therefore no longer officially
supported in Symfony 5.0. It still works, but in order to make
sure that a possibly introduced type declaration in a 5.x release
doesnt causes a type error, we migrate the middleware service
from array to ArrayObject.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 57

  1. Benjamin Franzke uploaded patch set 1 11/25/19, 10:22

  2. TYPO3com voted on patch set 1 V +1 11/25/19, 10:33 Completed build in 09m 13s on Mon, 25 Nov, 10:33 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38817

  3. Susi Moog uploaded patch set 2 11/29/19, 06:51

  4. Susi Moog voted on patch set 2 V +1 CR +1 11/29/19, 06:52

  5. TYPO3com voted on patch set 2 V +1 11/29/19, 07:05 Completed build in 09m 09s on Fri, 29 Nov, 07:05 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38913

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 11/29/19, 10:34

  7. Andreas Kienast merged patch set 3 11/29/19, 10:34