Review main Merged

62430[BUGFIX] Add rel="noreferrer" to all external links opened in new window

Jonas Eberle CR +2 V +2 Easy +23 −3 updated 01/14/20, 20:23

Commit message

This patch defines "opening in a new window" as links having an attribute
`target` that is not either empty, `_self`, `_top` or `_parent`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1724

  1. Jonas Eberle uploaded patch set 1 11/25/19, 15:48

  2. TYPO3com voted on patch set 1 V -1 11/25/19, 15:55 Completed build in 07m 22s on Mon, 25 Nov, 03:55 PM Test Summary: 39 of 48513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38824

  3. Jonas Eberle uploaded patch set 2 11/25/19, 16:09

  4. TYPO3com voted on patch set 2 V +1 11/25/19, 16:16 Completed build in 07m 08s on Mon, 25 Nov, 04:16 PM Test Summary: 48169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38825

  5. Jonas Eberle uploaded patch set 3 11/25/19, 17:13

  6. TYPO3com voted on patch set 3 V +1 11/25/19, 17:20 Completed build in 07m 08s on Mon, 25 Nov, 05:20 PM Test Summary: 48169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38826

  7. Jonas Eberle uploaded patch set 4 11/26/19, 07:29

  8. TYPO3com voted on patch set 4 V -1 11/26/19, 07:40 Completed build in 10m 50s on Tue, 26 Nov, 07:40 AM Test Summary: 37062 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38830

  9. TYPO3com commented on patch set 4 11/26/19, 08:37 Completed build in 1h 17m 55s on Tue, 26 Nov, 08:37 AM Test Summary: 47933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38830

  10. TYPO3com voted on patch set 4 V +1 11/26/19, 09:50 Completed build in 3h 38m 23s on Tue, 26 Nov, 09:50 AM Test Summary: 48169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38830

  11. Jörg Bösche voted on patch set 4 CR +1 12/01/19, 19:09

  12. Susi Moog voted on patch set 4 CR +1 12/02/19, 07:26

  13. Guido Schmechel voted on patch set 4 V +1 CR +1 12/24/19, 10:50

  14. Jörg Bösche voted on patch set 4 V +1 01/13/20, 14:08

  15. Tobi Kretschmann commented on patch set 4 01/14/20, 14:08

    ContentObjectRenderer.php:5151

    shouldn't we be type safe here with the third parameter set to true?
  16. Jonas Eberle commented on patch set 5 01/14/20, 14:59

    Published edit on patch set 4.
  17. Jonas Eberle commented on patch set 5 01/14/20, 15:00

    ContentObjectRenderer.php:5151 Reply

    Yes, of course! It wouldn't even make sense with type juggling. Thank you.
  18. TYPO3com voted on patch set 5 V +1 01/14/20, 15:11 Completed build in 10m 07s on Tue, 14 Jan, 03:11 PM Test Summary: 69590 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39914

  19. Tobi Kretschmann voted on patch set 5 CR +1 01/14/20, 16:48

  20. Susi Moog voted on patch set 5 CR +1 01/14/20, 20:13

  21. Jörg Bösche voted on patch set 5 V +1 CR +1 01/14/20, 20:17

  22. Susi Moog voted on patch set 5 V +1 01/14/20, 20:18

  23. Benni Mack voted on patch set 5 V +2 CR +2 01/14/20, 20:23

  24. Benni Mack merged patch set 6 01/14/20, 20:23