Review main Merged

62431[DOCS] Add example for saving uploaded files in SaveToDatabase finisher

TYPO3com CR +2 V +2 Normal +81 −0 updated 11/28/19, 10:22

Commit message

This adds an example on how to save uploaded files in ext:news'
`sys_file_reference` columns.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1522

  1. TYPO3com uploaded patch set 1 11/26/19, 08:21

  2. TYPO3com voted on patch set 1 V -1 11/26/19, 08:46 Completed build in 15m 02s on Tue, 26 Nov, 08:46 AM Test Summary: 47411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38831

  3. TYPO3com voted on patch set 1 V +1 11/26/19, 09:51 Completed build in 1h 34m 51s on Tue, 26 Nov, 09:51 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38831

  4. Tobi Kretschmann voted on patch set 1 CR +1 11/27/19, 08:33

  5. Oli Bartsch updated the commit message in patch set 2 11/27/19, 09:54

  6. TYPO3com voted on patch set 2 V -1 11/27/19, 10:28 Completed build in 14m 20s on Wed, 27 Nov, 10:27 AM Test Summary: 7 of 48509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38854

  7. TYPO3com commented on patch set 2 11/27/19, 10:33 Completed build in 33m 50s on Wed, 27 Nov, 10:33 AM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38854

  8. Daniel Siepmann uploaded patch set 3 11/27/19, 14:03

  9. Daniel Siepmann commented on patch set 3 V +1 11/27/19, 14:04

    Rendering works, not sure about the content.
  10. TYPO3com voted on patch set 3 V +1 11/27/19, 14:12 Completed build in 08m 21s on Wed, 27 Nov, 02:12 PM Test Summary: 48164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38857

  11. Daniel Goerz commented on patch set 3 11/27/19, 14:17

    Not only master, right?
  12. Oli Bartsch commented on patch set 3 11/27/19, 14:30

    Reply Unresolved

    Think the same but wasn't sure about it when I adjusted the commit message.
  13. Georg Ringer voted on patch set 3 V +1 CR +1 11/27/19, 20:43

  14. Björn Jacob commented on patch set 3 11/27/19, 21:41

    I would opt for porting it back to v9. There will be a merge conflict, since only v10 has this "I" subfolder. But I think it is quite important to have it in v9. Okay guys?
  15. Oli Bartsch commented on patch set 3 11/28/19, 06:52

    > Patch Set 3: > > I would opt for porting it back to v9. There will be a merge conflict, since only v10 has this "I" subfolder. But I think it is quite important to have it in v9. Okay guys? Yes, totally agree. Manually backport shouldn't be the problem. I could provide it as far as this got merged. Or should we make a separat patch for 9.5?
  16. Daniel Siepmann updated the commit message in patch set 4 11/28/19, 06:54

  17. Daniel Siepmann commented on patch set 4 CR +1 11/28/19, 06:55

    > Patch Set 3: > > > Patch Set 3: > > > > I would opt for porting it back to v9. There will be a merge conflict, since only v10 has this "I" subfolder. But I think it is quite important to have it in v9. Okay guys? > > Yes, totally agree. Manually backport shouldn't be the problem. I could provide it as far as this got merged. Or should we make a separat patch for 9.5? Added 9.5, I can give the backport a try and reach out to you Oliver if necessary. Would that be ok?
  18. Oli Bartsch commented on patch set 4 CR +1 11/28/19, 06:58

    > Patch Set 4: Code-Review+1 > > > Patch Set 3: > > > > > Patch Set 3: > > > > > > I would opt for porting it back to v9. There will be a merge conflict, since only v10 has this "I" subfolder. But I think it is quite important to have it in v9. Okay guys? > > > > Yes, totally agree. Manually backport shouldn't be the problem. I could provide it as far as this got merged. Or should we make a separat patch for 9.5? > > Added 9.5, I can give the backport a try and reach out to you Oliver if necessary. Would that be ok? Yep, I'm fine with it.
  19. Björn Jacob commented on patch set 4 V +1 CR +1 11/28/19, 07:10

    I can also assist you guys, np. Did it last week during the sprint couple of times :) Don't cherry pick for 9.5. Do the change manually and push with same Change-Id to 9.5.
  20. TYPO3com voted on patch set 4 V +1 11/28/19, 07:12 Completed build in 09m 14s on Thu, 28 Nov, 07:12 AM Test Summary: 48231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38872

  21. Daniel Siepmann voted on patch set 4 V +2 CR +2 11/28/19, 10:21

  22. Daniel Siepmann merged patch set 5 11/28/19, 10:22