Review main Merged

62433[TASK] Update friendsofphp/php-cs-fixer to 2.16.1

Alexander Schnitzler CR +2 V +2 Easy +22 −21 updated 11/26/19, 15:46

Commit message

composer require --dev friendsofphp/php-cs-fixer:"^2.16.1"

Raising the version brings support for running the fixer with
PHP 7.4.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1117

  1. Alexander Schnitzler uploaded patch set 1 11/26/19, 09:21

  2. TYPO3com voted on patch set 1 V -1 11/26/19, 09:28 Completed build in 06m 59s on Tue, 26 Nov, 09:28 AM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38834

  3. TYPO3com voted on patch set 1 V +1 11/26/19, 09:33 Completed build in 18m 49s on Tue, 26 Nov, 09:33 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38834

  4. Alexander Schnitzler updated the commit message in patch set 2 11/26/19, 09:39

  5. TYPO3com voted on patch set 2 V -1 11/26/19, 09:46 Completed build in 07m 00s on Tue, 26 Nov, 09:46 AM Test Summary: 17455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38836

  6. TYPO3com voted on patch set 2 V +1 11/26/19, 09:52 Completed build in 19m 55s on Tue, 26 Nov, 09:52 AM Test Summary: 48160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38836

  7. Benni Mack commented on patch set 2 11/26/19, 10:52

    should this also go to 9.5 (and possibly 8.7 if possible)?
  8. Alexander Schnitzler commented on patch set 2 11/26/19, 12:00

    > Patch Set 2: > > should this also go to 9.5 (and possibly 8.7 if possible)? I hoped for your decision. I'd say yes because this will be handy during backports.
  9. Benni Mack updated the commit message in patch set 3 11/26/19, 12:12

  10. TYPO3com voted on patch set 3 V -1 11/26/19, 12:20 Completed build in 07m 18s on Tue, 26 Nov, 12:20 PM Test Summary: 48150 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38837

  11. TYPO3com voted on patch set 3 V +1 11/26/19, 13:23 Completed build in 1h 17m 36s on Tue, 26 Nov, 01:23 PM Test Summary: 48157 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38837

  12. Oliver Klee voted on patch set 3 CR +1 11/26/19, 13:50

  13. Andreas Kienast voted on patch set 3 V +1 CR +1 11/26/19, 14:02

  14. Tobi Kretschmann voted on patch set 3 CR +1 11/26/19, 14:51

  15. Tobi Kretschmann voted on patch set 3 V +1 11/26/19, 15:38

  16. Benni Mack voted on patch set 3 V +2 CR +2 11/26/19, 15:46

  17. Benni Mack merged patch set 4 11/26/19, 15:46