Review main Merged

62437[TASK] Require rector/rector

Alexander Schnitzler CR +2 V +2 Expert +1437 −42 updated 11/27/19, 15:13

Commit message

composer require --dev rector/rector:"^0.5.0"

This commit introduces the requirement to rector/rector to
automatically process code changes by given set of rules.

To make this commit more meaningful, a first set "php53"
has been processed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1417

  1. Alexander Schnitzler uploaded patch set 1 11/27/19, 09:40

  2. TYPO3com voted on patch set 1 V +1 11/27/19, 09:55 Completed build in 14m 25s on Wed, 27 Nov, 09:55 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38852

  3. Alexander Schnitzler updated the commit message in patch set 2 11/27/19, 11:33

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 11/27/19, 11:38

  5. Andreas Kienast uploaded patch set 3 11/27/19, 11:40

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 11/27/19, 11:40

  7. TYPO3com voted on patch set 2 V +1 11/27/19, 11:41 Completed build in 07m 34s on Wed, 27 Nov, 11:41 AM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38855

  8. TYPO3com voted on patch set 3 V +1 11/27/19, 11:47 Completed build in 07m 08s on Wed, 27 Nov, 11:47 AM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38856

  9. Oliver Klee voted on patch set 3 CR +1 11/27/19, 12:16

  10. Georg Ringer commented on patch set 3 11/27/19, 13:21

    rector.yml:5

    shouldn't we add Test dir as well?
  11. Alexander Schnitzler commented on patch set 3 11/27/19, 13:38

    rector.yml:5 Reply

    Yes but it doesn't work yet because our autoloading isn't properly configured causing rector to crash. We could add custom autoloading for rector but I'd rather fix our test classes and fixtures instead.
  12. Andreas Kienast commented on patch set 3 11/27/19, 13:41

    rector.yml:5 Reply

    AFAICS the issue is caused due to wrong namespaces in some test classes.
  13. Andreas Kienast commented on patch set 3 11/27/19, 13:44

    rector.yml:5 Reply

    Alright, we also have a fixture class containing multiple classes and an issue with acceptance test stuff. I'd say we skip this for now.
  14. Alexander Schnitzler commented on patch set 3 11/27/19, 13:48

    rector.yml:5 Reply Unresolved

    Yes, that's my idea as well. Small steps forward, one at a time.
  15. Georg Ringer voted on patch set 3 V +1 CR +1 11/27/19, 15:10

  16. Andreas Kienast voted on patch set 3 V +2 CR +2 11/27/19, 15:13

  17. Andreas Kienast merged patch set 4 11/27/19, 15:13