Review main Merged

62438[TASK] Update phpdocumentor/reflection-docblock

Alexander Schnitzler CR +2 V +2 Normal +42 −146 updated 01/22/20, 15:15

Commit message

composer require phpdocumentor/reflection-docblock:"^4.3.2"
    composer require phpdocumentor/type-resolver:"~0.5"

Upating phpdocumentor/reflection-docblock to at least 4.3.2
allows updating phpdocumentor/type-resolver to a version higher
than 0.4 which is needed to get support for resolving collection
types in doc blocks which enables the removal of the custom type
resolving via extbase/Classes/Reflection/DocBlock/Tags/Var_.php.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2431

Show 46 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 11/27/19, 14:55

  2. TYPO3com voted on patch set 1 V +1 11/27/19, 15:02 Completed build in 07m 02s on Wed, 27 Nov, 03:02 PM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38860

  3. Alexander Schnitzler commented on patch set 1 11/27/19, 15:10

    > Patch Set 1: Verified+1 > > Completed build in 07m 02s on Wed, 27 Nov, 03:02 PM > Test Summary: 48165 passed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38860 Bamboo's result makes me wonder what caused this patch in the first place: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61702
  4. Alexander Schnitzler uploaded patch set 2 11/27/19, 17:36

  5. TYPO3com voted on patch set 2 V -1 11/27/19, 17:36 Completed build in 08s on Wed, 27 Nov, 05:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38864

  6. Alexander Schnitzler uploaded patch set 3 11/27/19, 17:50

  1. TYPO3com voted on patch set 3 V -1 11/27/19, 17:57 Completed build in 06m 38s on Wed, 27 Nov, 05:57 PM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38866

  2. TYPO3com voted on patch set 3 V +1 11/27/19, 18:01 Completed build in 17m 20s on Wed, 27 Nov, 06:01 PM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38866

  3. Alexander Schnitzler commented on patch set 3 11/27/19, 19:22

    So, coming back to this topic after about one year and after PHPStorm implementing the collection syntax (https://blog.jetbrains.com/phpstorm/2018/09/phpstorm-2018-3-eap-183-2635-12/) I found this PR (https://github.com/php-fig/fig-standards/pull/1102) that removes collections from the PSR-5 proposition (https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md). phpdocumentor/type-resolver implemented support for collection types however and they haven't been removed (yet?). https://github.com/phpDocumentor/TypeResolver/blob/1.0.1/src/Types/Collection.php I guess it's safe to use the official collection type although it's not part of PSR-5 any more but has chances to be added again. Meanwhile most of the PHP community adopted the idea of collections/generics. phpstan, phan and psalm do support them. https://www.reddit.com/r/PHP/comments/c650ux/phpstan_is_getting_generics_and_you_can_already/ So, it's up to us to decide whether we merge this patch or continue with our own type resolver.
  4. Alexander Schnitzler commented on patch set 3 11/27/19, 19:22

    This change is ready for review.
  5. Alexander Schnitzler commented on patch set 3 CR -1 11/27/19, 19:32

    This case also possibly changes and needs tests first. > /** > * @param ObjectStorage<Foo> > */ > public function setStorage($objectStorage) > { > }
  6. Oliver Klee commented on patch set 3 CR -1 11/27/19, 22:42

    Unresolved

    What's your number? ;-)
  7. Alexander Schnitzler updated the commit message in patch set 4 11/28/19, 16:51

  8. Alexander Schnitzler commented on patch set 4 11/28/19, 16:53

    > Patch Set 3: Code-Review-1 > > This case also possibly changes and needs tests first. > > > /** > > * @param ObjectStorage<Foo> > > */ > > public function setStorage($objectStorage) > > { > > } This doesn't need any attention.
  9. Alexander Schnitzler wrote 11/28/19, 16:54

    Topic set to extbase
  10. TYPO3com voted on patch set 4 V +1 11/28/19, 17:35 Completed build in 30m 44s on Thu, 28 Nov, 05:35 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38891

  11. Alexander Schnitzler uploaded patch set 5 12/03/19, 14:32

  12. Alexander Schnitzler wrote 12/03/19, 14:32

    Description set to "Rebase"
  13. TYPO3com voted on patch set 5 V +1 12/03/19, 14:42 Completed build in 10m 14s on Tue, 3 Dec, 02:42 PM Test Summary: 48367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39076

  14. Alexander Schnitzler commented on patch set 5 12/08/19, 11:00

    ping
  15. Daniel Goerz uploaded patch set 6 01/22/20, 12:21

  16. Daniel Goerz commented on patch set 6 01/22/20, 12:22

    conflicts resolved
  17. TYPO3com voted on patch set 6 V +1 01/22/20, 12:33 Completed build in 11m 24s on Wed, 22 Jan, 12:33 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40134

  18. Daniel Goerz voted on patch set 6 CR +1 01/22/20, 12:43

  19. Susi Moog voted on patch set 6 CR +1 01/22/20, 13:10

  20. Georg Ringer voted on patch set 6 V +1 CR +1 01/22/20, 13:15

  21. Susi Moog voted on patch set 6 V +1 01/22/20, 13:19

  22. Susi Moog voted on patch set 6 V +2 CR +2 01/22/20, 13:19

  23. Susi Moog merged patch set 7 01/22/20, 13:20