62439[TASK] Apply rector sets php54 and php55
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 25
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php+1 −1
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+5 −5
- typo3/sysext/extbase/Classes/Object/ObjectManager.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/PropertyType.php2+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php+1 −1
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/TypeHandlingUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPullParser.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPullParser.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/DatePicker.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/GeneratorClassesResolver.php+1 −1
- typo3/sysext/install/Classes/Updates/BackendUserConfigurationUpdate.php+1 −1
Show 5 more files
Review log 1216
-
Alexander Schnitzler uploaded patch set 1 11/27/19, 17:46
-
TYPO3com voted on patch set 1 V -1 11/27/19, 17:54 Completed build in 07m 42s on Wed, 27 Nov, 05:54 PM Test Summary: 48162 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38865
-
TYPO3com voted on patch set 1 V +1 11/27/19, 19:25 Completed build in 1h 46m 59s on Wed, 27 Nov, 07:25 PM Test Summary: 48163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38865
-
Alexander Schnitzler updated the commit message in patch set 2 11/27/19, 19:34
-
TYPO3com voted on patch set 2 V -1 11/27/19, 19:41 Completed build in 06m 59s on Wed, 27 Nov, 07:41 PM Test Summary: 48154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38867
-
Oliver Klee commented on patch set 2 CR -1 11/27/19, 19:52
InstallerController.php:269UnresolvedThis isn't a class name.InstallerController.php:294UnresolvedThis isn't a class name.InstallerController.php:363UnresolvedThis isn't a class name.InstallerController.php:454UnresolvedThis isn't a class name.SilentConfigurationUpgradeService.php:822UnresolvedThis isn't a class name.SilentConfigurationUpgradeService.php:851UnresolvedThis isn't a class name.Check.php:65UnresolvedThis isn't a class name. -
Alexander Schnitzler uploaded patch set 3 11/28/19, 09:38
-
TYPO3com voted on patch set 3 V +1 11/28/19, 09:48 Completed build in 10m 06s on Thu, 28 Nov, 09:48 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38878
-
Oliver Klee commented on patch set 3 CR +1 11/28/19, 10:04
Beautiful! -
Susi Moog voted on patch set 3 CR +1 11/29/19, 12:23
-
Andreas Kienast voted on patch set 3 CR +1 11/29/19, 12:25
-
Susi Moog voted on patch set 3 V +1 11/29/19, 12:35
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 11/29/19, 12:36
-
Anja Leichsenring merged patch set 4 11/29/19, 12:36
-
Oliver Hader commented on patch set 4 01/29/20, 19:17
PropertyType.php:188That was basically wrong... since the term stems from 2009, and \WeakReference was introduced with PHP 7.4 only -
Alexander Schnitzler commented on patch set 4 01/30/20, 08:27
PropertyType.php:188ReplyYes, I know. I found that issue as well with phpstan. Has been fixed these days with this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039
SiteListCommand.php:63Unresolved