Review main Merged

62439[TASK] Apply rector sets php54 and php55

Alexander Schnitzler CR +2 V +2 Normal +41 −31 updated 01/30/20, 08:27

Commit message

php bin/rector process

Both sets php54 and php55 have been applied at the
same time because set php54 didn't result in any
changes.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1216

  1. Alexander Schnitzler uploaded patch set 1 11/27/19, 17:46

  2. TYPO3com voted on patch set 1 V -1 11/27/19, 17:54 Completed build in 07m 42s on Wed, 27 Nov, 05:54 PM Test Summary: 48162 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38865

  3. TYPO3com voted on patch set 1 V +1 11/27/19, 19:25 Completed build in 1h 46m 59s on Wed, 27 Nov, 07:25 PM Test Summary: 48163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38865

  4. Alexander Schnitzler updated the commit message in patch set 2 11/27/19, 19:34

  5. TYPO3com voted on patch set 2 V -1 11/27/19, 19:41 Completed build in 06m 59s on Wed, 27 Nov, 07:41 PM Test Summary: 48154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38867

  6. Oliver Klee commented on patch set 2 CR -1 11/27/19, 19:52

    SiteListCommand.php:63 Unresolved

    This isn't a class name.

    InstallerController.php:269 Unresolved

    This isn't a class name.

    InstallerController.php:294 Unresolved

    This isn't a class name.

    InstallerController.php:363 Unresolved

    This isn't a class name.

    InstallerController.php:454 Unresolved

    This isn't a class name.

    SilentConfigurationUpgradeService.php:822 Unresolved

    This isn't a class name.

    SilentConfigurationUpgradeService.php:851 Unresolved

    This isn't a class name.

    Check.php:65 Unresolved

    This isn't a class name.
  7. Alexander Schnitzler uploaded patch set 3 11/28/19, 09:38

  8. TYPO3com voted on patch set 3 V +1 11/28/19, 09:48 Completed build in 10m 06s on Thu, 28 Nov, 09:48 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38878

  9. Oliver Klee commented on patch set 3 CR +1 11/28/19, 10:04

    Beautiful!
  10. Susi Moog voted on patch set 3 CR +1 11/29/19, 12:23

  11. Andreas Kienast voted on patch set 3 CR +1 11/29/19, 12:25

  12. Susi Moog voted on patch set 3 V +1 11/29/19, 12:35

  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/29/19, 12:36

  14. Anja Leichsenring merged patch set 4 11/29/19, 12:36

  15. Oliver Hader commented on patch set 4 01/29/20, 19:17

    PropertyType.php:188

    That was basically wrong... since the term stems from 2009, and \WeakReference was introduced with PHP 7.4 only
  16. Alexander Schnitzler commented on patch set 4 01/30/20, 08:27

    PropertyType.php:188 Reply

    Yes, I know. I found that issue as well with phpstan. Has been fixed these days with this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039