62446[DOCS] Improve documentation in EXT:fluid_styled_content
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2132
Show 57 earlier messages
-
Michael Telgkamp uploaded patch set 1 11/28/19, 10:24
-
TYPO3com voted on patch set 1 V +1 11/28/19, 10:36 Completed build in 11m 15s on Thu, 28 Nov, 10:36 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38879
-
Thomas W. voted on patch set 1 CR +1 11/28/19, 10:50
-
Andreas Kienast updated the commit message in patch set 2 11/28/19, 11:01
-
TYPO3com voted on patch set 2 V +1 11/28/19, 11:09 Completed build in 07m 56s on Thu, 28 Nov, 11:09 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38881
-
Thomas W. voted on patch set 2 V +1 CR +1 11/28/19, 11:25
-
Daniel Siepmann commented on patch set 2 11/28/19, 13:42
-
Michael Telgkamp uploaded patch set 3 11/28/19, 13:53
-
Michael Telgkamp commented on patch set 3 11/28/19, 13:54
Index.rst:13ReplyI added semantic linebreaks for all paragraphs in this document. -
TYPO3com voted on patch set 3 V -1 11/28/19, 14:01 Completed build in 08m 24s on Thu, 28 Nov, 02:01 PM Test Summary: 48128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38885
-
TYPO3com voted on patch set 3 V +1 11/28/19, 15:18 Completed build in 1h 33m 07s on Thu, 28 Nov, 03:18 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38885
-
Daniel Siepmann uploaded patch set 4 11/29/19, 09:05
-
Daniel Siepmann uploaded patch set 5 11/29/19, 09:07
-
TYPO3com voted on patch set 4 V +1 11/29/19, 09:15 Completed build in 09m 19s on Fri, 29 Nov, 09:15 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38916
-
TYPO3com voted on patch set 5 V +1 11/29/19, 09:19 Completed build in 09m 33s on Fri, 29 Nov, 09:19 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38917
-
Michael Telgkamp commented on patch set 5 CR -1 11/29/19, 09:23
Some more improvement suggestionsIndex.rst:73some lines above `your-icon-identifier` is usedIndex.rst:137"has to be placed at the path" instead of "have to be placed in the file"?Index.rst:138I do not get, what this sentence tells me. Did you mean "This file will load because it is registered as static file above."?Index.rst:140..., paths for them need to be added. -
Michael Telgkamp wrote 11/29/19, 09:23
Removed reviewer Thomas W.. -
Daniel Siepmann uploaded patch set 6 11/29/19, 11:35
-
Daniel Siepmann commented on patch set 6 11/29/19, 11:37
Index.rst:73ReplyDoneIndex.rst:137ReplyActually it is a file, not a path. So why should we switch to path here?Index.rst:138ReplyI've adjusted the sentences, please have another look.Index.rst:140ReplyDone -
TYPO3com voted on patch set 6 V +1 11/29/19, 12:25 Completed build in 54m 11s on Fri, 29 Nov, 12:25 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38930
-
Michael Telgkamp uploaded patch set 7 12/02/19, 08:09
-
TYPO3com voted on patch set 7 V +1 12/02/19, 08:16 Completed build in 07m 01s on Mon, 2 Dec, 08:16 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38989
-
Daniel Siepmann uploaded patch set 8 12/03/19, 06:49
-
TYPO3com voted on patch set 8 V -1 12/03/19, 06:56 Completed build in 07m 19s on Tue, 3 Dec, 06:56 AM Test Summary: 48301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39042
-
TYPO3com commented on patch set 8 12/03/19, 07:35 Completed build in 08m 20s on Tue, 3 Dec, 07:35 AM Test Summary: 12 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39045
-
TYPO3com voted on patch set 8 V +1 12/03/19, 13:10 Completed build in 07m 54s on Tue, 3 Dec, 01:10 PM Test Summary: 48367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39073
-
Michael Telgkamp commented on patch set 8 V +1 CR +1 12/03/19, 13:40
Index.rst:137ReplyI am happy with your change.Index.rst:138ReplyDone -
Sybille Peters commented on patch set 8 CR -1 12/06/19, 09:30
While I like the changes, I think we might go even further and make some additional small improvements while we are at it. I will push another patch.Index.rst:36> Since this part is written for developers, it will not explain in full detail how an extension works. I would remove this paragraph.Index.rst:46comma: First,Index.rst:178This will load the Fluid template file :file:`NewContentElement.html`.Index.rst:186UnresolvedSuggestion ... you must create the Fluid template :file:`your_extension_key/Resources/Private/Templates/NewContentElement.html`.Index.rst:187Unresolved> This template will be located at the directory and file name entered in :file:`setup.typoscript` using the parameter :typoscript:`templateName`. This has already been explained above. I would remove this. -
Lidia Demin commented on patch set 8 CR -1 12/10/19, 13:14
The refactoring to a more objective description is good. Also, a lot of useful information was added. -1 is only because of the minor typo and I agree to the changes proposed by Sybille.Index.rst:25UnresolvedWould change it to "these" if you are changing "manipulation" to "manipulations" -
Sybille Peters commented on patch set 8 12/10/19, 13:48
@Michael As discussed, I migrated the page to "TYPO3 Explained". You can find the new page in: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/ContentElements/AddingYourOwnContentElements.html The commit from this patch has not been applied yet. Next steps: 1) Continue work in "TYPO3 Explained" and create a PR there. 2) This patch can be abandoned 3) Sybille: Create new patch in fluid_styled_content docs to remove existing content "Adding your own content elements" and create redirect to "TYPO3 Explained" 4) Sybille: apply all for versions master, 9.5 and 8.7. Please contact me on Slack if there are any questions.Index.rst:36ReplyDoneIndex.rst:46ReplyDoneIndex.rst:178ReplyDone -
Sybille Peters commented on patch set 8 12/13/19, 16:48
This patch can be abandoned. The page has been moved to "TYPO3 Explained". The changes from this patch were added as pull request: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/691 -
Daniel Goerz abandoned the change 12/15/19, 14:39
What Sybille said
Index.rst:13