Review main Merged

62448[TASK] Apply rector set php56

Alexander Schnitzler CR +2 V +2 Normal +192 −49 updated 12/18/19, 13:29

Commit message

php bin/rector process

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jan Stockfisch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 99

Show 79 more files

Review log 2839

Show 814 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 11/28/19, 11:54

  2. TYPO3com voted on patch set 1 V -1 11/28/19, 11:54 Completed build in 08s on Thu, 28 Nov, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38882

  3. Alexander Schnitzler rebased onto patch set 2 11/29/19, 15:10

  4. TYPO3com voted on patch set 2 V -1 11/29/19, 15:18 Completed build in 07m 21s on Fri, 29 Nov, 03:18 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38949

  5. Alexander Schnitzler updated the commit message in patch set 3 11/29/19, 15:19

  6. TYPO3com voted on patch set 3 V -1 11/29/19, 15:28 Completed build in 08m 14s on Fri, 29 Nov, 03:28 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38950

  7. TYPO3com commented on patch set 2 11/29/19, 15:30 Completed build in 27m 33s on Fri, 29 Nov, 03:30 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38949

  8. Andreas Kienast commented on patch set 3 CR -1 11/29/19, 16:49

    Looks like a lot of initializations are done as `null` where an empty array would be appropriate.
  9. Alexander Schnitzler commented on patch set 3 11/30/19, 07:41

    > Patch Set 3: Code-Review-1 > > Looks like a lot of initializations are done as `null` where an empty array would be appropriate. Yep, and we can't fully trust that our tests find all cases where null might be breaking. I will go through all classes and check which default value we should apply.
  10. Alexander Schnitzler uploaded patch set 4 12/01/19, 14:46

  11. TYPO3com voted on patch set 4 V -1 12/01/19, 14:53 Completed build in 07m 05s on Sun, 1 Dec, 02:53 PM Test Summary: 48118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38983

  12. TYPO3com voted on patch set 4 V +1 12/01/19, 14:59 Completed build in 19m 43s on Sun, 1 Dec, 02:59 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38983

  13. Alexander Schnitzler commented on patch set 4 12/01/19, 15:00

    This change is ready for review.
  14. Alexander Schnitzler uploaded patch set 5 12/03/19, 14:28

  1. Alexander Schnitzler wrote 12/03/19, 14:32

    Description set to "Rebase"
  2. TYPO3com voted on patch set 5 V +1 12/03/19, 14:39 Completed build in 11m 21s on Tue, 3 Dec, 02:39 PM Test Summary: 48367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39075

  3. Alexander Schnitzler commented on patch set 5 12/08/19, 10:59

    ping
  4. Alexander Schnitzler wrote 12/10/19, 07:09

    Topic set to rector
  5. Alexander Schnitzler commented on patch set 5 CR -1 12/10/19, 10:47

    Needs to be rebased once all other rector related patches are merged.
  6. Alexander Schnitzler uploaded patch set 6 12/10/19, 13:12

  7. TYPO3com voted on patch set 6 V +1 12/10/19, 13:22 Completed build in 10m 15s on Tue, 10 Dec, 01:22 PM Test Summary: 68706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39305

  8. Andreas Kienast voted on patch set 6 CR +1 12/11/19, 12:08

  9. Manuel Selbach commented on patch set 6 12/12/19, 10:51

    Thanks for the work! Some questions from my side

    PageTitle.php:91

    Could get rid of the complete `else` here, if we define it at the beginning and remove that key in the if statement?

    InputColorPickerElement.php:119

    Where is `$evalData` set before that change? Shouldn't this be `$func` instead?

    AbstractItemProvider.php:1312

    Where are `$dynamicItems` and `$staticValues` used in that method? Is this complete if statement needed here?

    PageRepository.php:637

    In general to unset or set $row to null would not be expected by the interface, as it defines that $row is an array, if i see that correctly: typo3/sysext/core/Classes/Domain/Repository/PageRepositoryGetRecordOverlayHookInterface.php /** * Enables to postprocess a record overlay * * @param string $table * @param array $row * @param int $sys_language_content * @param string $OLmode * @param PageRepository $parent */ public function getRecordOverlay_postProcess($table, &$row, &$sys_language_content, $OLmode, PageRepository $parent);

    ErrorHandler.php:109

    In case of `E_USER_ERROR` or `E_RECOVERABLE_ERROR` the `$flashMessageSeverity` will now be set to `FlashMessage::OK`. Is that intended?

    YamlSource.php:126

    Did this method return any value before? If not, the return could be removed and the annotation could be updated, IMO

    ContentObjectRenderer.php:5505

    I guess, this is an old thing here before parse_str() was provided: https://review.typo3.org/57770 Wouldn't it be `$excludedQueryParts['id'] = 0` right now?

    SchedulerModuleController.php:1194

    Should we change this is to `$cronErrorCode > 0` with that change?
  10. Alexander Schnitzler commented on patch set 6 12/12/19, 13:21

    InputColorPickerElement.php:119 Reply Unresolved

    Yes, I guess the wrong variable is used here.

    AbstractItemProvider.php:1312 Reply Unresolved

    Looks like dead code indeed.

    PageRepository.php:637 Reply Unresolved

    That's true but this patch does not aim to fix current behaviour.

    ErrorHandler.php:109 Reply Unresolved

    That's ok. See the comment regarding flash message severity please. No flash message is sent actually.

    YamlSource.php:126 Reply Unresolved

    True, this could be directly removed. It's totally superfluous.

    ContentObjectRenderer.php:5505 Reply Unresolved

    True, but I wouldn't change this in this patch. I could imagine that we have a bug report for this already and I would solve this in another patch.

    SchedulerModuleController.php:1194 Reply Unresolved

    Yes, I assume it's safe to use count here without breaking stuff.
  11. Alexander Schnitzler commented on patch set 6 12/12/19, 13:24

    PageTitle.php:91 Reply

    Ack
  12. Alexander Schnitzler uploaded patch set 7 12/12/19, 14:02

  13. TYPO3com voted on patch set 7 V +1 12/12/19, 14:48 Completed build in 46m 17s on Thu, 12 Dec, 02:48 PM Test Summary: 68718 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39363

  14. Andreas Kienast commented on patch set 7 CR -1 12/14/19, 14:04

    PageTitle.php:72

    unset($data['cacheEnabled']) or $data['cacheEnabled'] = false is missing?

    SchedulerModuleController.php:1194

    Why count()? $cronErrorCode is an int.
  15. Alexander Schnitzler commented on patch set 7 12/14/19, 14:09

    PageTitle.php:72 Reply

    Yes, because that's the same behavior as before. Inside the if clause the array is not extended but reinitialized.

    SchedulerModuleController.php:1194 Reply Unresolved

    True *facepalm*
  16. Alexander Schnitzler commented on patch set 8 12/14/19, 14:10

    Published edit on patch set 7.
  17. Andreas Kienast commented on patch set 8 CR +1 12/14/19, 14:13

    PageTitle.php:72 Reply Unresolved

    True, I didn't see that
  18. TYPO3com voted on patch set 8 V +1 12/14/19, 14:18 Completed build in 07m 46s on Sat, 14 Dec, 02:18 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39424

  19. Jan Stockfisch voted on patch set 8 V +1 CR +1 12/16/19, 07:27

  20. Jan Stockfisch rebased onto patch set 9 12/16/19, 07:55

  21. TYPO3com voted on patch set 9 V +1 12/16/19, 08:09 Completed build in 13m 24s on Mon, 16 Dec, 08:09 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39444

  22. Jan Stockfisch commented on patch set 9 V +1 CR +1 12/16/19, 08:25

    Rebase was unintended. Sorry für the spam
  23. Anja Leichsenring voted on patch set 9 V +1 CR +1 12/18/19, 11:30

  24. Andreas Kienast voted on patch set 9 V +2 CR +2 12/18/19, 13:29

  25. Andreas Kienast merged patch set 10 12/18/19, 13:29