62448[TASK] Apply rector set php56
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Jan Stockfisch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Jan Stockfisch +1
- TYPO3com +1 CI
Issues 1
Files 99
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php5+3 −2
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+1 −0
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −0
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+1 −0
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −0
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −0
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php2+2 −0
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −0
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php2+2 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php+2 −2
- typo3/sysext/backend/Classes/History/RecordHistory.php+1 −0
- typo3/sysext/backend/Classes/Provider/PageTsBackendLayoutDataProvider.php+1 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −1
Show 79 more files
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowInitializeNewTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+14 −0
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+1 −0
- typo3/sysext/core/Classes/Command/SiteListCommand.php+2 −0
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+1 −0
- typo3/sysext/core/Classes/Core/Bootstrap.php+2 −0
- typo3/sysext/core/Classes/Database/QueryGenerator.php+4 −3
- typo3/sysext/core/Classes/Database/QueryView.php+2 −0
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+3 −0
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+3 −0
- typo3/sysext/core/Classes/DataHandling/Model/RecordStateFactory.php+2 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php2+3 −3
- typo3/sysext/core/Classes/Error/ErrorHandler.php2+1 −0
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariant.php+1 −0
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+2 −0
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −0
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+11 −7
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/FolderRestriction.php+1 −0
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+3 −3
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −2
- typo3/sysext/core/Classes/Utility/MathUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DefaultRestrictionContainerTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaSqliteTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+5 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+3 −0
- typo3/sysext/felogin/Classes/Redirect/RedirectModeHandler.php+10 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/BytesViewHelperTest.php+2 −2
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/PropertyPathsExtractor.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+1 −0
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php2+0 −3
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+1 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+4 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −0
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+1 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −0
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+1 −0
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −2
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −0
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.php+1 −0
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −0
- typo3/sysext/indexed_search/Classes/Indexer.php+3 −1
- typo3/sysext/install/Classes/Controller/UpgradeController.php+1 −0
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+1 −0
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+1 −0
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+3 −0
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+3 −1
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+2 −0
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+1 −0
- typo3/sysext/redirects/Classes/Service/SlugService.php+1 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+1 −0
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −0
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+1 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php4+3 −3
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php+1 −0
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −0
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −0
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −0
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+1 −0
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −0
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+2 −0
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+1 −0
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+1 −0
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −0
- rector.yml+2 −2
Review log 2839
Show 814 earlier messages
-
Alexander Schnitzler uploaded patch set 1 11/28/19, 11:54
-
TYPO3com voted on patch set 1 V -1 11/28/19, 11:54 Completed build in 08s on Thu, 28 Nov, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38882
-
Alexander Schnitzler rebased onto patch set 2 11/29/19, 15:10
-
TYPO3com voted on patch set 2 V -1 11/29/19, 15:18 Completed build in 07m 21s on Fri, 29 Nov, 03:18 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38949
-
Alexander Schnitzler updated the commit message in patch set 3 11/29/19, 15:19
-
TYPO3com voted on patch set 3 V -1 11/29/19, 15:28 Completed build in 08m 14s on Fri, 29 Nov, 03:28 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38950
-
TYPO3com commented on patch set 2 11/29/19, 15:30 Completed build in 27m 33s on Fri, 29 Nov, 03:30 PM Test Summary: 511 of 48722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38949
-
Andreas Kienast commented on patch set 3 CR -1 11/29/19, 16:49
Looks like a lot of initializations are done as `null` where an empty array would be appropriate. -
Alexander Schnitzler commented on patch set 3 11/30/19, 07:41
> Patch Set 3: Code-Review-1 > > Looks like a lot of initializations are done as `null` where an empty array would be appropriate. Yep, and we can't fully trust that our tests find all cases where null might be breaking. I will go through all classes and check which default value we should apply. -
Alexander Schnitzler uploaded patch set 4 12/01/19, 14:46
-
TYPO3com voted on patch set 4 V -1 12/01/19, 14:53 Completed build in 07m 05s on Sun, 1 Dec, 02:53 PM Test Summary: 48118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38983
-
TYPO3com voted on patch set 4 V +1 12/01/19, 14:59 Completed build in 19m 43s on Sun, 1 Dec, 02:59 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38983
-
Alexander Schnitzler commented on patch set 4 12/01/19, 15:00
This change is ready for review. -
Alexander Schnitzler uploaded patch set 5 12/03/19, 14:28
-
Alexander Schnitzler wrote 12/03/19, 14:32
Description set to "Rebase" -
TYPO3com voted on patch set 5 V +1 12/03/19, 14:39 Completed build in 11m 21s on Tue, 3 Dec, 02:39 PM Test Summary: 48367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39075
-
Alexander Schnitzler commented on patch set 5 12/08/19, 10:59
ping -
Alexander Schnitzler wrote 12/10/19, 07:09
Topic set to rector -
Alexander Schnitzler commented on patch set 5 CR -1 12/10/19, 10:47
Needs to be rebased once all other rector related patches are merged. -
Alexander Schnitzler uploaded patch set 6 12/10/19, 13:12
-
TYPO3com voted on patch set 6 V +1 12/10/19, 13:22 Completed build in 10m 15s on Tue, 10 Dec, 01:22 PM Test Summary: 68706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39305
-
Andreas Kienast voted on patch set 6 CR +1 12/11/19, 12:08
-
Manuel Selbach commented on patch set 6 12/12/19, 10:51
Thanks for the work! Some questions from my sidePageTitle.php:91Could get rid of the complete `else` here, if we define it at the beginning and remove that key in the if statement?InputColorPickerElement.php:119Where is `$evalData` set before that change? Shouldn't this be `$func` instead?AbstractItemProvider.php:1312Where are `$dynamicItems` and `$staticValues` used in that method? Is this complete if statement needed here?PageRepository.php:637In general to unset or set $row to null would not be expected by the interface, as it defines that $row is an array, if i see that correctly: typo3/sysext/core/Classes/Domain/Repository/PageRepositoryGetRecordOverlayHookInterface.php /** * Enables to postprocess a record overlay * * @param string $table * @param array $row * @param int $sys_language_content * @param string $OLmode * @param PageRepository $parent */ public function getRecordOverlay_postProcess($table, &$row, &$sys_language_content, $OLmode, PageRepository $parent);ErrorHandler.php:109In case of `E_USER_ERROR` or `E_RECOVERABLE_ERROR` the `$flashMessageSeverity` will now be set to `FlashMessage::OK`. Is that intended?YamlSource.php:126Did this method return any value before? If not, the return could be removed and the annotation could be updated, IMOContentObjectRenderer.php:5505I guess, this is an old thing here before parse_str() was provided: https://review.typo3.org/57770 Wouldn't it be `$excludedQueryParts['id'] = 0` right now?SchedulerModuleController.php:1194Should we change this is to `$cronErrorCode > 0` with that change? -
Alexander Schnitzler commented on patch set 6 12/12/19, 13:21
InputColorPickerElement.php:119Reply UnresolvedYes, I guess the wrong variable is used here.AbstractItemProvider.php:1312Reply UnresolvedLooks like dead code indeed.PageRepository.php:637Reply UnresolvedThat's true but this patch does not aim to fix current behaviour.ErrorHandler.php:109Reply UnresolvedThat's ok. See the comment regarding flash message severity please. No flash message is sent actually.YamlSource.php:126Reply UnresolvedTrue, this could be directly removed. It's totally superfluous.ContentObjectRenderer.php:5505Reply UnresolvedTrue, but I wouldn't change this in this patch. I could imagine that we have a bug report for this already and I would solve this in another patch.SchedulerModuleController.php:1194Reply UnresolvedYes, I assume it's safe to use count here without breaking stuff. -
Alexander Schnitzler commented on patch set 6 12/12/19, 13:24
PageTitle.php:91ReplyAck -
Alexander Schnitzler uploaded patch set 7 12/12/19, 14:02
-
TYPO3com voted on patch set 7 V +1 12/12/19, 14:48 Completed build in 46m 17s on Thu, 12 Dec, 02:48 PM Test Summary: 68718 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39363
-
Andreas Kienast commented on patch set 7 CR -1 12/14/19, 14:04
PageTitle.php:72unset($data['cacheEnabled']) or $data['cacheEnabled'] = false is missing?SchedulerModuleController.php:1194Why count()? $cronErrorCode is an int. -
Alexander Schnitzler commented on patch set 7 12/14/19, 14:09
PageTitle.php:72ReplyYes, because that's the same behavior as before. Inside the if clause the array is not extended but reinitialized.SchedulerModuleController.php:1194Reply UnresolvedTrue *facepalm* -
Alexander Schnitzler commented on patch set 8 12/14/19, 14:10
Published edit on patch set 7. -
Andreas Kienast commented on patch set 8 CR +1 12/14/19, 14:13
PageTitle.php:72Reply UnresolvedTrue, I didn't see that -
TYPO3com voted on patch set 8 V +1 12/14/19, 14:18 Completed build in 07m 46s on Sat, 14 Dec, 02:18 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39424
-
Jan Stockfisch voted on patch set 8 V +1 CR +1 12/16/19, 07:27
-
Jan Stockfisch rebased onto patch set 9 12/16/19, 07:55
-
TYPO3com voted on patch set 9 V +1 12/16/19, 08:09 Completed build in 13m 24s on Mon, 16 Dec, 08:09 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39444
-
Jan Stockfisch commented on patch set 9 V +1 CR +1 12/16/19, 08:25
Rebase was unintended. Sorry für the spam -
Anja Leichsenring voted on patch set 9 V +1 CR +1 12/18/19, 11:30
-
Andreas Kienast voted on patch set 9 V +2 CR +2 12/18/19, 13:29
-
Andreas Kienast merged patch set 10 12/18/19, 13:29