62450[BUGFIX] Fix broken Fluid templates
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Claus Due +1
- Rens Admiraal +1
- Alexander Schnitzler +1
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Resources/Private/Partials/ContextSensitiveHelp/TableOfContents.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ContextSensitiveHelp/Index.html2+1 −1
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Edit.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+2 −2
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/UnresolvedDependencies.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+1 −1
- typo3/sysext/felogin/Resources/Private/Email/Templates/PasswordRecovery.html+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/FileList/Search.html+8 −8
- typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Be/Widget/Paginate/Index.html+6 −6
- typo3/sysext/redirects/Resources/Private/Partials/Pagination.html+5 −5
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/reports/Resources/Private/Templates/Report/Index.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/TaskList.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/PageZero.html+1 −1
Review log 1011
-
Patrick Broens uploaded patch set 1 11/28/19, 14:20
-
Benni Mack commented on patch set 1 11/28/19, 14:39
Awesome, Patrick! -
Rens Admiraal commented on patch set 1 CR +1 11/28/19, 14:53
> Patch Set 1: > > Awesome, Patrick! Yeah! -
Patrick Broens commented on patch set 1 11/28/19, 15:03
> Patch Set 1: > > Awesome, Patrick! I hope these are all. Did search for `arguments:{`, `arguments: {`, `parameters:{` and `parameters: {`. -
TYPO3com voted on patch set 1 V +1 11/28/19, 15:05 Completed build in 13m 12s on Thu, 28 Nov, 03:05 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38886
-
Alexander Schnitzler commented on patch set 1 CR +1 11/28/19, 15:34
Unresolved
In my opinion this should go into 8.7 as well. -
Claus Due commented on patch set 1 CR -2 11/28/19, 16:02
All appears good with one exception (see comment)Index.html:11This must be `'{action: _all}'` since `_all` is a (pseudo-)variable and with quotes it becomes a string. -
Claus Due commented on patch set 1 CR +1 11/28/19, 16:06
Sorry, I misread the code. Looks good altogether - unfortunately I cannot test it right now.Index.html:11ReplyDone -
Benni Mack voted on patch set 1 V +1 CR +1 11/29/19, 20:48
-
Susi Moog voted on patch set 1 V +2 CR +2 11/29/19, 21:24
-
Susi Moog merged patch set 2 11/29/19, 21:24