Review main Merged

62450[BUGFIX] Fix broken Fluid templates

Patrick Broens CR +2 V +2 Normal +33 −33 updated 11/29/19, 21:24

Commit message

In some versions of PHP there is a PCRE bug, which will be triggered when
using an unquoted array syntax in Fluid templates, leading to an error
and possibly not able to display the rendered template.

This is solved by using the quoted array syntax where it is not used yet.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Claus Due +1
    • Rens Admiraal +1
    • Alexander Schnitzler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1011

  1. Patrick Broens uploaded patch set 1 11/28/19, 14:20

  2. Benni Mack commented on patch set 1 11/28/19, 14:39

    Awesome, Patrick!
  3. Rens Admiraal commented on patch set 1 CR +1 11/28/19, 14:53

    > Patch Set 1: > > Awesome, Patrick! Yeah!
  4. Patrick Broens commented on patch set 1 11/28/19, 15:03

    > Patch Set 1: > > Awesome, Patrick! I hope these are all. Did search for `arguments:{`, `arguments: {`, `parameters:{` and `parameters: {`.
  5. TYPO3com voted on patch set 1 V +1 11/28/19, 15:05 Completed build in 13m 12s on Thu, 28 Nov, 03:05 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38886

  6. Alexander Schnitzler commented on patch set 1 CR +1 11/28/19, 15:34

    Unresolved

    In my opinion this should go into 8.7 as well.
  7. Claus Due commented on patch set 1 CR -2 11/28/19, 16:02

    All appears good with one exception (see comment)

    Index.html:11

    This must be `'{action: _all}'` since `_all` is a (pseudo-)variable and with quotes it becomes a string.
  8. Claus Due commented on patch set 1 CR +1 11/28/19, 16:06

    Sorry, I misread the code. Looks good altogether - unfortunately I cannot test it right now.

    Index.html:11 Reply

    Done
  9. Benni Mack voted on patch set 1 V +1 CR +1 11/29/19, 20:48

  10. Susi Moog voted on patch set 1 V +2 CR +2 11/29/19, 21:24

  11. Susi Moog merged patch set 2 11/29/19, 21:24