Review main Merged

62451[BUGFIX] Use native phpunit functionality in Fluid tests

Benni Mack CR +2 V +2 Normal +157 −37 updated 11/29/19, 10:19

Commit message

Some "methods" used in ViewHelpers to mock a class (RenderingContext)
which only uses a fixture to avoid constructor calls
can be achieved by using phpunit's getMockBuilder() logic
itself, making this class in the testing framework
useless. TYPO3 Core should not depend on this,
but rather use native phpunit logic.

Some other things are moved to the specific classes
where they are needed, so setUp() will be much faster
for other ViewHelper test classes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1530

Show 35 earlier messages
  1. Benni Mack uploaded patch set 1 11/28/19, 15:34

  2. Benni Mack uploaded patch set 2 11/28/19, 15:38

  3. TYPO3com voted on patch set 1 V +1 11/28/19, 15:41 Completed build in 07m 34s on Thu, 28 Nov, 03:41 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38887

  4. TYPO3com voted on patch set 2 V -1 11/28/19, 15:45 Completed build in 06m 39s on Thu, 28 Nov, 03:45 PM Test Summary: 8 of 48426 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38888

  5. Susi Moog commented on patch set 3 11/28/19, 16:08

    Published edit on patch set 2.
  1. Benni Mack uploaded patch set 4 11/28/19, 16:09

  2. TYPO3com voted on patch set 3 V -1 11/28/19, 16:14 Completed build in 05m 52s on Thu, 28 Nov, 04:14 PM Test Summary: 30 of 35197 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38889

  3. TYPO3com voted on patch set 4 V -1 11/28/19, 16:18 Completed build in 09m 13s on Thu, 28 Nov, 04:18 PM Test Summary: 8 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38890

  4. Benni Mack uploaded patch set 5 11/28/19, 20:42

  5. TYPO3com voted on patch set 5 V -1 11/28/19, 20:51 Completed build in 08m 13s on Thu, 28 Nov, 08:51 PM Test Summary: 6 of 35350 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38897

  6. Anja Leichsenring uploaded patch set 6 11/28/19, 21:53

  7. TYPO3com voted on patch set 6 V -1 11/28/19, 21:54 Completed build in 21s on Thu, 28 Nov, 09:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38899

  8. Anja Leichsenring uploaded patch set 7 11/28/19, 21:54

  9. TYPO3com voted on patch set 7 V -1 11/28/19, 21:55 Completed build in 12s on Thu, 28 Nov, 09:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38901

  10. Anja Leichsenring uploaded patch set 8 11/28/19, 21:55

  11. TYPO3com voted on patch set 8 V -1 11/28/19, 21:56 Completed build in 13s on Thu, 28 Nov, 09:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38903

  12. Anja Leichsenring uploaded patch set 9 11/28/19, 22:01

  13. TYPO3com voted on patch set 9 V -1 11/28/19, 22:27 Completed build in 27s on Thu, 28 Nov, 10:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38905

  14. Susi Moog commented on patch set 10 11/29/19, 05:47

    Published edit on patch set 9.
  15. TYPO3com voted on patch set 10 V -1 11/29/19, 05:48 Completed build in 17s on Fri, 29 Nov, 05:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38908

  16. Susi Moog commented on patch set 11 11/29/19, 05:52

    Published edit on patch set 10.
  17. TYPO3com voted on patch set 11 V -1 11/29/19, 06:00 Completed build in 07m 27s on Fri, 29 Nov, 06:00 AM Test Summary: 72 of 48205 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38909

  18. Susi Moog uploaded patch set 12 11/29/19, 06:22

  19. TYPO3com voted on patch set 12 V -1 11/29/19, 06:29 Completed build in 07m 45s on Fri, 29 Nov, 06:29 AM Test Summary: 47867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38910

  20. TYPO3com voted on patch set 12 V +1 11/29/19, 06:37 Completed build in 22m 57s on Fri, 29 Nov, 06:37 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38910

  21. TYPO3com voted on patch set 12 V -1 11/29/19, 09:36 Completed build in 42m 22s on Fri, 29 Nov, 09:36 AM Test Summary: 1 of 45868 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38915

  22. TYPO3com voted on patch set 12 V +1 11/29/19, 09:39 Completed build in 1h 27m 42s on Fri, 29 Nov, 09:39 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38915

  23. Anja Leichsenring voted on patch set 12 V +1 CR +1 11/29/19, 09:42

  24. Andreas Kienast voted on patch set 12 V +2 CR +2 11/29/19, 10:19

  25. Andreas Kienast merged patch set 13 11/29/19, 10:19