Review 9.5 Merged

62462[BUGFIX] Use RequestFactory for downloading mirrors and check response properly

Richard Haeser CR +2 V +2 Easy +30 −17 updated 12/06/19, 13:43

Commit message

The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.

In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Richard Haeser commented on patch set 1 12/06/19, 11:34

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/install/Classes/Service/LanguagePackService.php
  2. TYPO3com voted on patch set 1 V -1 12/06/19, 11:34 Completed build in 22s on Fri, 6 Dec, 11:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1677

  3. Richard Haeser uploaded patch set 2 12/06/19, 12:10

  4. Richard Haeser commented on patch set 2 12/06/19, 12:11

    This change is ready for review.
  5. Andreas Kienast voted on patch set 2 CR +1 12/06/19, 12:17

  6. TYPO3com voted on patch set 2 V +1 12/06/19, 12:20 Completed build in 09m 40s on Fri, 6 Dec, 12:20 PM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1682

  7. Richard Haeser voted on patch set 2 V +2 CR +2 12/06/19, 13:43

  8. Richard Haeser merged patch set 3 12/06/19, 13:43