Review 9.5 Merged

62467[BUGFIX] Remove leading slash from backendLogo path

Benni Mack CR +2 V +2 Easy +1 −1 updated 12/10/19, 11:29

Commit message

As the extension configuration field `backendLogo` isn't resolved
by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`,
it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage)
not possible to add a path with a leading slash.

As this is neither explicit allowed nor disallowed, this unifies the
behavior by removing a possible leading slash from the defined path
before it gets resolved as it's already the case for the other fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/10/19, 11:16

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/10/19, 11:28 Completed build in 11m 17s on Tue, 10 Dec, 11:28 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1691

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/10/19, 11:29

  4. Benni Mack merged patch set 2 12/10/19, 11:29