Review main Merged

6249[BUGFIX] config.compressJs enables itself

Steffen Gebert CR +2 V +2 Easy +4 −3 updated 06/03/13, 20:49

Commit message

Due to a compat_mode backwards compatibility setting, the new option
config.compressJs
enables itself automatically, although not desired

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1
  • Verified V +2
    • Stefan Galinski +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 20

  1. Stefan Galinski merged patch set 1 10/24/11, 19:57

  2. Stefan Galinski commented on patch set 1 10/24/11, 19:57

    Verified; Looks good to me, but someone else must approve
  3. Xavier Perseguers commented on patch set 1 10/24/11, 19:57

    Looks good to me, but someone else must approve Will fix the one with the other change...

    class.tslib_fe.php:2059

    Should be set to 0 instead because it is never set to some default value and will trigger PHP warnings
  4. Steffen Gebert commented on patch set 1 10/24/11, 19:57

    Grr... Jenkins mistake.. it voted for the wrong change.. (but was right in principle..)
  5. Stefan Galinski commented on patch set 2 10/24/11, 19:57

    Verified; Looks good to me, but someone else must approve
  6. Xavier Perseguers commented on patch set 2 1 comment 10/24/11, 19:57

    I would prefer that you didn't submit this
  7. Steffen Gebert uploaded patch set 2 10/24/11, 19:57

  8. Steffen Gebert commented on patch set 2 10/24/11, 19:57

    circumventing Jenkins.. hopefully it doesn't vote me down again.. (it shouldn't)
  9. Stefan Galinski commented on patch set 3 V 0 10/24/11, 19:57

    by team member; Looks good to me, approved
  10. Xavier Perseguers commented on patch set 3 10/24/11, 19:57

    Verified; Looks good to me, but someone else must approve
  11. Steffen Gebert commented on patch set 3 10/24/11, 19:57

    now initializing it to 0.. although this is an exception from the usual "not initialized" TypoScript value style ;)
  12. Steffen Gebert commented on patch set 3 10/24/11, 19:57

    (1 inline comment)
  13. Steffen Gebert uploaded patch set 3 10/24/11, 19:57

  14. Jigal van Hemert commented on patch set 3 10/24/11, 19:57

    (1 inline comment)

    class.tslib_fe.php:2061

    It's never checked against a value, but only used in if($GLOBALS['TSFE']->config['config']['compressJs']) { . Leaving it empty would have the same effect.
  15. Jigal van Hemert commented on patch set 3 V 0 10/24/11, 19:57

    by team member; Looks good to me, approved I can live with the lines of code that aren't really useuful; it doesn't do any harm and won't cost much performance.
  16. Andy Grunwald commented on patch set 1 10/24/11, 19:57

    Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 1 10/24/11, 19:57

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2265/ : FAILURE
  18. Mr. Jenkins commented on patch set 2 10/24/11, 19:57

  19. Mr. Jenkins commented on patch set 3 10/24/11, 19:57

  20. Xavier Perseguers commented on patch set 3 10/24/11, 19:57

    (1 inline comment)