Review main Merged

62491[BUGFIX] Open a new tab if window name in backend is `newTYPO3frontendWindow`

Andreas Kienast CR +2 V +2 Easy +2 −0 updated 11/29/19, 18:24

Commit message

If a preview is opened via the TYPO3 backend, the opened window has the
name `newTYPO3frontendWindow` to ensure only one preview window is open.
However, if somebody changes in such window into the TYPO3 backend, the
window name is not changed, causing that such preview links are opened
in the same window again.

This patch resets the window name before a preview is opened to ensure
that previews are always opened in a new window.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 11/29/19, 13:35

  2. TYPO3com voted on patch set 1 V +1 11/29/19, 13:43 Completed build in 07m 56s on Fri, 29 Nov, 01:43 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38943

  3. Oli Bartsch commented on patch set 1 11/29/19, 14:05

    #62489 isn't correct AFAICS.
  4. Andreas Kienast commented on patch set 1 11/29/19, 14:08

    > Patch Set 1: > > #62489 isn't correct AFAICS. That's right, I should use the ticket, not the patch...
  5. Andreas Kienast updated the commit message in patch set 2 11/29/19, 14:09

  6. TYPO3com voted on patch set 2 V +1 11/29/19, 14:17 Completed build in 07m 50s on Fri, 29 Nov, 02:17 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38946

  7. Susi Moog voted on patch set 2 V +1 CR +1 11/29/19, 14:22

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 11/29/19, 18:24

  9. Daniel Goerz merged patch set 3 11/29/19, 18:24