Review main Merged

62493[TASK] Migrate Tests from _callRef to _call

Benni Mack CR +2 V +2 Normal +108 −57 updated 12/02/19, 07:36

Commit message

Tests should be consistent and reflect the
way we do things in Core. However, testing
framework offers too many different ways to do things,
and "_callRef" is one of that.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 711

  1. Benni Mack uploaded patch set 1 11/29/19, 14:48

  2. TYPO3com voted on patch set 1 V -1 11/29/19, 14:56 Completed build in 08m 04s on Fri, 29 Nov, 02:56 PM Test Summary: 48045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38948

  3. TYPO3com voted on patch set 1 V +1 11/29/19, 15:09 Completed build in 29m 06s on Fri, 29 Nov, 03:09 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38948

  4. Susi Moog uploaded patch set 2 12/01/19, 11:12

  5. TYPO3com voted on patch set 2 V +1 12/01/19, 11:19 Completed build in 07m 35s on Sun, 1 Dec, 11:19 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38982

  6. Benni Mack updated the commit message in patch set 3 12/01/19, 16:17

  7. TYPO3com voted on patch set 3 V +1 12/01/19, 16:25 Completed build in 07m 38s on Sun, 1 Dec, 04:25 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38985

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 12/02/19, 07:32

  9. Frank Nägler voted on patch set 3 V +1 CR +1 12/02/19, 07:36

  10. Frank Nägler voted on patch set 3 V +2 CR +2 12/02/19, 07:36

  11. Frank Nägler merged patch set 4 12/02/19, 07:36