Review main Merged

62494[TASK] Integrate NormalizedParams into Install Tool

Benni Mack CR +2 V +2 Normal +90 −37 updated 11/29/19, 20:15

Commit message

The normalizedparams middleware is not executed in the install
tool anymore, which is added by the NormalizedParamsAttribute
middleware.

In addition, the NormalizedParams class now contains factory
methods for building up NormalizedParams based on $_SERVER
or a PSR-7 request object.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 710

  1. Benni Mack uploaded patch set 1 11/29/19, 15:30

  2. Mathias Brodala commented on patch set 1 11/29/19, 15:32

    NormalizedParams.php:852 Unresolved

    This should be called "createFromServerParams" to be explicit.
  3. TYPO3com voted on patch set 1 V +1 11/29/19, 15:38 Completed build in 07m 26s on Fri, 29 Nov, 03:38 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38951

  4. Andreas Kienast uploaded patch set 2 11/29/19, 18:11

  5. Andreas Kienast voted on patch set 2 CR +1 11/29/19, 18:11

  6. TYPO3com voted on patch set 2 V -1 11/29/19, 18:18 Completed build in 07m 09s on Fri, 29 Nov, 06:18 PM Test Summary: 48366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38956

  7. TYPO3com voted on patch set 2 V +1 11/29/19, 19:49 Completed build in 1h 45m 26s on Fri, 29 Nov, 07:49 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38956

  8. Susi Moog voted on patch set 2 V +1 CR +1 11/29/19, 20:00

  9. Georg Ringer voted on patch set 2 V +2 CR +2 11/29/19, 20:15

  10. Georg Ringer merged patch set 3 11/29/19, 20:15