Review main Merged

62496[BUGFIX] Use RequestFactory for downloading mirrors and check response properly

Andreas Kienast CR +2 V +2 Normal +51 −19 updated 12/06/19, 11:34

Commit message

The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.

In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2127

Show 12 earlier messages
  1. Andreas Kienast uploaded patch set 1 11/29/19, 17:21

  2. TYPO3com voted on patch set 1 V +1 11/29/19, 17:29 Completed build in 07m 13s on Fri, 29 Nov, 05:29 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38954

  1. Jörg Bösche voted on patch set 1 CR +1 12/01/19, 19:06

  2. Oli Bartsch commented on patch set 1 12/02/19, 07:48

    LanguagePackService.php:196

    What about also logging if the status code is not 200 to provide particularly information?
  3. Andreas Kienast commented on patch set 1 12/02/19, 08:43

    LanguagePackService.php:196 Reply Unresolved

    Maybe
  4. Andreas Kienast uploaded patch set 2 12/02/19, 11:03

  5. Andreas Kienast uploaded patch set 3 12/02/19, 11:36

  6. TYPO3com voted on patch set 3 V +1 12/02/19, 11:44 Completed build in 08m 26s on Mon, 2 Dec, 11:44 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39003

  7. TYPO3com voted on patch set 2 V +1 12/02/19, 12:10 Completed build in 1h 05m 08s on Mon, 2 Dec, 12:10 PM Test Summary: 48369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39000

  8. Jörg Bösche voted on patch set 3 CR +1 12/02/19, 12:59

  9. Oli Bartsch voted on patch set 3 CR +1 12/02/19, 15:41

  10. Susi Moog voted on patch set 3 CR +1 12/02/19, 16:26

  11. Susi Moog voted on patch set 3 V +1 12/02/19, 16:31

  12. Jan Stockfisch voted on patch set 3 CR +1 12/02/19, 16:53

  13. Georg Ringer commented on patch set 3 CR -1 12/02/19, 22:32

    what about the other getUrl call for each language pack in line 283?
  14. Andreas Kienast commented on patch set 3 12/04/19, 07:23

    > Patch Set 3: Code-Review-1 > > what about the other getUrl call for each language pack in line 283? ack
  15. Andreas Kienast uploaded patch set 4 12/04/19, 07:26

  16. TYPO3com voted on patch set 4 V +1 12/04/19, 07:34 Completed build in 07m 36s on Wed, 4 Dec, 07:34 AM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39089

  17. Georg Ringer commented on patch set 4 CR -1 12/04/19, 09:06

    LanguagePackService.php:213

    do we really need that twice?
  18. Andreas Kienast commented on patch set 4 12/04/19, 09:17

    LanguagePackService.php:213 Reply Unresolved

    Of course not...
  19. Andreas Kienast commented on patch set 5 12/04/19, 09:19

    Published edit on patch set 4.
  20. TYPO3com voted on patch set 5 V -1 12/04/19, 09:27 Completed build in 08m 14s on Wed, 4 Dec, 09:27 AM Test Summary: 68627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39091

  21. TYPO3com voted on patch set 5 V +1 12/04/19, 10:00 Completed build in 49m 29s on Wed, 4 Dec, 10:00 AM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39091

  22. Georg Ringer voted on patch set 5 V +1 CR +1 12/04/19, 20:45

  23. Oli Bartsch voted on patch set 5 CR +1 12/04/19, 21:52

  24. Richard Haeser voted on patch set 5 V +2 CR +2 12/06/19, 11:34

  25. Richard Haeser merged patch set 6 12/06/19, 11:34