Review 9.5 Merged

62499[TASK] Update doctrine/annotations dependency

Benni Mack CR +2 V +2 Normal +38 −30 updated 11/29/19, 21:34

Commit message

TYPO3 Core now requires at least doctrine/annotations
1.7, effectively helping to upgrade to PHP 7.4.

Composer command:
  composer require doctrine/annotations:"^1.7" --update-with-all-dependencies

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 35

  1. Benni Mack uploaded patch set 1 11/29/19, 20:55

  2. TYPO3com voted on patch set 1 V -1 11/29/19, 21:05 Completed build in 10m 44s on Fri, 29 Nov, 09:05 PM Test Summary: 1 of 51466 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1634

  3. TYPO3com voted on patch set 1 V +1 11/29/19, 21:30 Completed build in 46m 02s on Fri, 29 Nov, 09:30 PM Test Summary: 50998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1634

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/29/19, 21:34

  5. Benni Mack merged patch set 2 11/29/19, 21:34