Review 9.5 Merged

62500[BUGFIX] Fix broken Fluid templates

Susi Moog CR +2 V +2 Normal +35 −35 updated 12/05/19, 15:22

Commit message

In some versions of PHP there is a PCRE bug, which will be triggered when
using an unquoted array syntax in Fluid templates, leading to an error
and possibly not able to display the rendered template.

This is solved by using the quoted array syntax where it is not used yet.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Patrick Broens +1
  • Verified V +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1318

  1. Susi Moog uploaded patch set 1 11/29/19, 21:25

  2. TYPO3com voted on patch set 1 V -1 11/29/19, 21:35 Completed build in 10m 04s on Fri, 29 Nov, 09:35 PM Test Summary: 1 of 51465 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1635

  3. Patrick Broens commented on patch set 1 CR -1 11/30/19, 16:32

    One file has too many changes, the reason why Bamboo is complaining.

    Search.html:105 Unresolved

    Too much has changed here (lines 105-117), probably because it was copied from 'master'. Only line 109 should have a change (data-url attribute)
  4. Patrick Broens commented on patch set 1 12/03/19, 13:57

    typo3/sysext/felogin/Resources/Private/Email/Templates/PasswordRecovery.html is added as empty file. This file is not part in the V9 branch, so can be deleted

    UnresolvedDependencies.html:2 Unresolved

    Do not change tabs to spaces in this commit
  5. Patrick Broens uploaded patch set 2 12/03/19, 13:59

  6. TYPO3com voted on patch set 2 V -1 12/03/19, 14:07 Completed build in 08m 28s on Tue, 3 Dec, 02:07 PM Test Summary: 1 of 51466 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1647

  7. Patrick Broens uploaded patch set 3 12/03/19, 14:17

  8. Patrick Broens uploaded patch set 4 12/03/19, 14:20

  9. TYPO3com voted on patch set 3 V -1 12/03/19, 14:26 Completed build in 09m 20s on Tue, 3 Dec, 02:26 PM Test Summary: 1 of 51466 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1648

  10. TYPO3com voted on patch set 4 V -1 12/03/19, 14:33 Completed build in 11m 11s on Tue, 3 Dec, 02:33 PM Test Summary: 40803 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1649

  11. Patrick Broens uploaded patch set 5 12/03/19, 14:37

  12. TYPO3com voted on patch set 5 V +1 12/03/19, 14:48 Completed build in 10m 54s on Tue, 3 Dec, 02:48 PM Test Summary: 50998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1650

  13. Patrick Broens voted on patch set 5 CR +1 12/03/19, 14:48

  14. Susi Moog commented on patch set 5 CR +1 12/04/19, 06:56

    thx for fixing my cherry-pick :)
  15. Oli Bartsch voted on patch set 5 V +1 CR +1 12/04/19, 07:16

  16. Oliver Klee voted on patch set 5 CR +1 12/04/19, 09:45

  17. Susi Moog voted on patch set 5 V +2 CR +2 12/05/19, 15:22

  18. Susi Moog merged patch set 6 12/05/19, 15:22