62503[TASK] Use inject methods instead of "inject" base test method
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Susi Moog +1
-
Verified V +2 Done
- Andreas Kienast +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 21
- typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php+7 −9
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+5 −1
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+7 −3
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php3+3 −8
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+18 −20
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/ObjectConverterTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMapperTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ListUtilityTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.php+2 −4
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestHandlerTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+6 −6
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/LinkViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ImageViewHelperTest.php+10 −16
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+2 −6
Review log 810
-
Benni Mack uploaded patch set 1 12/02/19, 09:13
-
TYPO3com voted on patch set 1 V -1 12/02/19, 09:57 Completed build in 16m 21s on Mon, 2 Dec, 09:57 AM Test Summary: 84 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38995
-
Benni Mack uploaded patch set 2 12/02/19, 15:28
-
TYPO3com voted on patch set 2 V +1 12/02/19, 16:00 Completed build in 31m 40s on Mon, 2 Dec, 04:00 PM Test Summary: 48376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39016
-
Susi Moog voted on patch set 2 V +1 CR +1 12/02/19, 16:24
-
Andreas Kienast commented on patch set 2 V +2 CR +1 12/02/19, 16:35
-
Benni Mack commented on patch set 2 12/02/19, 16:36
DataHandlerTest.php:587Replythe context is set in the closure by the second parameter ($newThis). -
Susi Moog commented on patch set 2 12/02/19, 16:36
DataHandlerTest.php:587Reply Unresolvednope, second parameter of closure::bind is "this" in the context of the closure. -
Andreas Kienast voted on patch set 2 CR +2 12/02/19, 16:37
-
Andreas Kienast merged patch set 3 12/02/19, 16:37
DataHandlerTest.php:587