Review main Merged

62508[BUGFIX] Avoid cross-dependency in Extbase dispatcher

Benni Mack CR +2 V +2 Easy +18 −28 updated 12/02/19, 16:56

Commit message

Extbase's old signal slot dispatcher / core should not
use classes that are not explicitly
required for the miminum packages.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Benni Mack uploaded patch set 1 12/02/19, 13:43

  2. Claus Due commented on patch set 1 12/02/19, 13:57

    Dispatcher.php:185 Unresolved

    I would add a code comment informing that the choice of string vs. `::class` is intentional and must not be changed unless dependencies are made explicit. Seems more than likely that someone in the future sees this and converts them, which then won't be detected as an actual error.
  3. Benni Mack commented on patch set 2 12/02/19, 14:01

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 12/02/19, 14:01 Completed build in 16s on Mon, 2 Dec, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39012

  5. Benni Mack commented on patch set 3 12/02/19, 14:05

    Published edit on patch set 2.
  6. Claus Due commented on patch set 3 12/02/19, 14:08

    Elaborated the comment a bit to inform about the one and only case in which it would be OK to change this to ::class again.
  7. Claus Due commented on patch set 4 12/02/19, 14:08

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 1 V +1 12/02/19, 14:42 Completed build in 56m 31s on Mon, 2 Dec, 02:42 PM Test Summary: 48376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39011

  9. TYPO3com voted on patch set 3 V +1 12/02/19, 15:08 Completed build in 1h 02m 40s on Mon, 2 Dec, 03:08 PM Test Summary: 48371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39013

  10. TYPO3com voted on patch set 4 V +1 12/02/19, 15:10 Completed build in 1h 01m 27s on Mon, 2 Dec, 03:10 PM Test Summary: 48372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39014

  11. Richard Haeser voted on patch set 4 V +1 CR +1 12/02/19, 15:11

  12. Daniel Goerz voted on patch set 4 CR +1 12/02/19, 16:21

  13. Daniel Goerz voted on patch set 4 V +1 12/02/19, 16:53

  14. Daniel Goerz voted on patch set 4 V +2 CR +2 12/02/19, 16:56

  15. Daniel Goerz merged patch set 5 12/02/19, 16:56