Review main Merged

62518[BUGFIX] Avoid resolving default values of static property in ClassSchema

Oliver Hader CR +2 V +2 Easy +19 −1 updated 12/03/19, 08:53

Commit message

Building reflection cache in ClassSchema on static class properties will
lead to side-effects. For instance when ConnectionPool is analyzed for
being used with Extbase dependency injection and has been used already
during runtime - which is very likely - static property $connections is
going to hold all runtime connections.

https://www.php.net/manual/en/reflectionclass.getdefaultproperties.php:
> This method only works for static properties when used on internal
> classes. The default value of a static class property can not be
> tracked when using this method on user defined classes.

That's why default values of static properties are not resolved anymore.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1017

  1. Oliver Hader uploaded patch set 1 12/02/19, 23:17

  2. TYPO3com voted on patch set 1 V -1 12/02/19, 23:24 Completed build in 06m 46s on Mon, 2 Dec, 11:24 PM Test Summary: 48117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39040

  3. TYPO3com voted on patch set 1 V +1 12/02/19, 23:27 Completed build in 17m 11s on Mon, 2 Dec, 11:27 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39040

  4. Georg Ringer voted on patch set 1 CR +1 12/03/19, 07:09

  5. Susi Moog voted on patch set 1 V +1 CR +1 12/03/19, 07:16

  6. Oliver Hader updated the commit message in patch set 2 12/03/19, 07:58

  7. TYPO3com voted on patch set 2 V -1 12/03/19, 08:05 Completed build in 06m 32s on Tue, 3 Dec, 08:05 AM Test Summary: 48116 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39050

  8. Alexander Schnitzler uploaded patch set 3 12/03/19, 08:13

  9. TYPO3com voted on patch set 3 V -1 12/03/19, 08:13 Completed build in 12s on Tue, 3 Dec, 08:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39051

  10. Alexander Schnitzler uploaded patch set 4 12/03/19, 08:14

  11. TYPO3com voted on patch set 2 V +1 12/03/19, 08:18 Completed build in 26m 46s on Tue, 3 Dec, 08:18 AM Test Summary: 48373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39050

  12. TYPO3com voted on patch set 4 V -1 12/03/19, 08:21 Completed build in 07m 06s on Tue, 3 Dec, 08:21 AM Test Summary: 48086 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39052

  13. TYPO3com voted on patch set 4 V +1 12/03/19, 08:25 Completed build in 18m 21s on Tue, 3 Dec, 08:25 AM Test Summary: 48379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39052

  14. Alexander Schnitzler voted on patch set 4 V +1 CR +1 12/03/19, 08:28

  15. Alexander Schnitzler wrote 12/03/19, 08:28

    Topic set to extbase
  16. Susi Moog voted on patch set 4 V +2 CR +2 12/03/19, 08:53

  17. Susi Moog merged patch set 5 12/03/19, 08:53