Review main Merged

62522[BUGFIX] Make LinkAnalyzer available for DI

Andreas Kienast CR +2 V +2 Easy +3 −0 updated 12/03/19, 10:59

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Siepmann +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Susi Moog +1

Issues 2

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 12/03/19, 10:42

  2. Susi Moog voted on patch set 1 V +1 CR +1 12/03/19, 10:45

  3. Daniel Siepmann voted on patch set 1 CR +1 12/03/19, 10:48

  4. Oliver Hader voted on patch set 1 V +2 CR +2 12/03/19, 10:55

  5. Oliver Hader merged patch set 2 12/03/19, 10:55

  6. TYPO3com voted on patch set 1 V +1 12/03/19, 10:56 Completed build in 13m 58s on Tue, 3 Dec, 10:56 AM Test Summary: 48379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39062

  7. Alexander Schnitzler commented on patch set 2 12/03/19, 10:57

    Services.yaml:12

    Post -1. Well, it would be better to inject the LinkAnalyzer in those classes that use makeInstance to create an instance. Making this class public works but is actually not what we want. If we keep doing so, we don't need DI as the Container will then only be used as a singleton storage.
  8. Alexander Schnitzler commented on patch set 2 12/03/19, 10:59

    Services.yaml:12 Reply Unresolved

    Also the title is misleading. The class is already available for DI. What this patch does is making the service public to bypass DI and to ask the Container directly.