Review main Merged

62531[TASK] Implicitly add backend routes to router using DI factories

Benjamin Franzke CR +2 V +2 Normal +90 −57 updated 01/31/20, 09:53

Commit message

All Routes.php information for Backend routes are now collected
via Dependency Injection.

That means Bootstrap::initializeBackendRouter() doesn't
need to be called explicitly from a middleware anymore.

The Router class will always have the routes populated
whenever it is initialized / needed.

We use DI factories to collect and add the backend routes.
The routes from the extension configuration files are still cached,
but the cache is managed by a service provider.

We adapt the ServiceProviderCompilationPass to keep track
of the return type of extended services where the extension
may not have a return type declaration (because of the
dynamic closures in PseudoServiceProvider). We do that
to properly notify symfony DI that the routes are
stored as ArrayObject.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1220

  1. Benjamin Franzke uploaded patch set 1 12/03/19, 19:24

  2. Benjamin Franzke wrote 12/03/19, 19:24

    Topic set to di
  3. TYPO3com voted on patch set 1 V -1 12/03/19, 19:31 Completed build in 06m 42s on Tue, 3 Dec, 07:30 PM Test Summary: 68303 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39084

  4. TYPO3com commented on patch set 1 12/03/19, 19:54 Completed build in 07m 11s on Tue, 3 Dec, 07:54 PM Test Summary: 68141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39085

  5. TYPO3com voted on patch set 1 V +1 12/03/19, 20:05 Completed build in 07m 05s on Tue, 3 Dec, 08:05 PM Test Summary: 68636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39086

  6. Benjamin Franzke uploaded patch set 2 12/06/19, 09:05

  7. TYPO3com voted on patch set 2 V +1 12/06/19, 09:12 Completed build in 06m 56s on Fri, 6 Dec, 09:12 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39134

  8. Benni Mack uploaded patch set 3 01/29/20, 10:21

  9. TYPO3com voted on patch set 3 V +1 01/29/20, 10:35 Completed build in 13m 46s on Wed, 29 Jan, 10:35 AM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40312

  10. Benjamin Franzke updated the commit message in patch set 4 01/29/20, 15:13

  11. TYPO3com voted on patch set 4 V +1 01/29/20, 15:40 Completed build in 20m 28s on Wed, 29 Jan, 03:40 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40328

  12. Benjamin Franzke commented on patch set 4 01/29/20, 15:40

    This change is ready for review.
  13. Benni Mack commented on patch set 4 01/29/20, 16:28

    ServiceProvider.php:98 Unresolved

    we used this Typo3Version() class now in the other code.
  14. Benni Mack uploaded patch set 5 01/30/20, 07:19

  15. Benni Mack uploaded patch set 6 01/30/20, 07:21

  16. Benni Mack voted on patch set 6 V +1 CR +1 01/30/20, 07:21

  17. TYPO3com voted on patch set 5 V -1 01/30/20, 07:41 Completed build in 22m 21s on Thu, 30 Jan, 07:41 AM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40344

  18. TYPO3com voted on patch set 6 V +1 01/30/20, 07:52 Completed build in 20m 07s on Thu, 30 Jan, 07:52 AM Test Summary: 70839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40345

  19. Susi Moog voted on patch set 6 V +2 CR +2 01/31/20, 09:52

  20. Susi Moog merged patch set 7 01/31/20, 09:53