Review 9.5 Merged

62532[TASK] Add index to slug field

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 12/27/19, 22:29

Commit message

`TYPO3\CMS\Core\Routing\PageRouter::getPagesFromDatabaseForCandidates`
looks-up candidates for the page using the `slug` field (and also sorts by
this value). This has some serious impact on the website performance on
systems with lots of pages. In order to optimize this, an index should be
set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Oli Bartsch uploaded patch set 1 12/04/19, 10:08

  2. Oli Bartsch commented on patch set 1 12/04/19, 10:11

    To avoid further controversy on the main patch, this is the backport on which we can discuss if this should go into 9.5.
  3. TYPO3com voted on patch set 1 V +1 12/04/19, 10:17 Completed build in 08m 55s on Wed, 4 Dec, 10:17 AM Test Summary: 50998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1653

  4. anonymized-52878 commented on patch set 1 V +1 CR +1 12/04/19, 11:04

    Confirmed that it works (MariaDB 10.2)
  5. Jonas Eberle commented on patch set 1 V +1 12/04/19, 13:31

    Checked with MariaDB 10.2 SET GLOBAL log_queries_not_using_indexes='ON'; This is the offending query: SELECT `uid`, `l10n_parent`, `pid`, `slug` FROM `pages` WHERE (`sys_language_uid` = 0) AND (`slug` IN ('/')) AND ((`pages`.`deleted` = 0) AND ((`pages`.`t3ver_state` <= 0) AND (`pages`.`t3ver_oid` = 0))) ORDER BY `slug` desc; The patch fixes that.
  6. Jonas Eberle voted on patch set 1 CR +1 12/06/19, 17:38

  7. Guido Schmechel voted on patch set 1 V +1 CR +1 12/24/19, 10:47

  8. Oliver Hader commented on patch set 1 12/27/19, 18:05

    What about TYPO3 v10 - is it handled there already?
  9. Jonas Eberle commented on patch set 1 12/27/19, 18:44

  10. Oliver Hader commented on patch set 2 12/27/19, 21:28

    Published edit on patch set 1.
  11. Oliver Hader voted on patch set 2 V +1 CR +1 12/27/19, 21:28

  12. Jonas Eberle voted on patch set 2 V +1 CR +1 12/27/19, 21:54

  13. TYPO3com voted on patch set 2 V +1 12/27/19, 22:27 Completed build in 57m 21s on Fri, 27 Dec, 10:27 PM Test Summary: 72577 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1761

  14. Benni Mack voted on patch set 2 V +2 CR +2 12/27/19, 22:29

  15. Benni Mack merged patch set 3 12/27/19, 22:29