Review main Merged

62534[TASK] Add index to l10n_source field

Riny van Tiggelen CR +2 V +2 Easy +1 −0 updated 01/14/20, 07:47

Commit message

The database field which is created based on TCA setting
translationSource, now automatically gets an index.
This improves the performace in (for example) the
migration from pages_language_overlay to pages.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Oli Bartsch +1
    • Jonas Eberle +1
    • Guido Schmechel +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Oli Bartsch +1
    • Jonas Eberle +1
    • Richard Haeser +1
    • Jörg Bösche +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Riny van Tiggelen uploaded patch set 1 12/05/19, 07:54

  2. TYPO3com voted on patch set 1 V -1 12/05/19, 08:01 Completed build in 07m 01s on Thu, 5 Dec, 08:01 AM Test Summary: 1 of 69088 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39098

  3. TYPO3com voted on patch set 1 V +1 12/05/19, 08:09 Completed build in 21m 42s on Thu, 5 Dec, 08:09 AM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39098

  4. Oli Bartsch commented on patch set 1 V +1 12/05/19, 08:34

    Worked for me. But I think we should use a different term for the key name. We could just use the column name `l10n_source` like also done for e.g. `t3ver_oid` or `slug` (another pending patch). Maybe also `transaltion_source` would be a proper one.
  5. Riny van Tiggelen uploaded patch set 2 12/05/19, 09:53

  6. Riny van Tiggelen commented on patch set 2 12/05/19, 09:55

    > Patch Set 1: Verified+1 > > Worked for me. But I think we should use a different term for the key name. We could just use the column name `l10n_source` like also done for e.g. `t3ver_oid` or `slug` (another pending patch). Maybe also `transaltion_source` would be a proper one. Agreed, changed it to 'translation_source' since the field can be something other than 'l10n_source'.
  7. TYPO3com voted on patch set 2 V +1 12/05/19, 10:01 Completed build in 07m 26s on Thu, 5 Dec, 10:01 AM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39101

  8. Richard Haeser voted on patch set 2 V +1 CR +1 12/05/19, 10:24

  9. Guido Schmechel voted on patch set 2 CR +1 12/05/19, 10:49

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 12/05/19, 11:59

  11. Richard Haeser voted on patch set 2 CR 0 12/05/19, 13:25

  12. Richard Haeser commented on patch set 2 12/05/19, 13:27

    Are there more situations where this field is used? How is performance on those places? Is the constraint always only on this field or in combination with other fields?
  13. Jonas Eberle voted on patch set 2 V +1 CR +1 12/23/19, 09:50

  14. Jörg Bösche voted on patch set 2 V +1 CR +1 01/13/20, 12:50

  15. Andreas Kienast voted on patch set 2 CR +1 01/13/20, 12:51

  16. Steffen Frese voted on patch set 2 V +1 CR +1 01/13/20, 14:02

  17. Tobi Kretschmann voted on patch set 2 V +2 CR +2 01/14/20, 07:47

  18. Tobi Kretschmann merged patch set 3 01/14/20, 07:47