Review main Merged

62538[BUGFIX] Do not process original files

Florian Schuhmann CR +2 V +2 Easy +2 −2 updated 02/26/20, 19:27

Commit message

The existing ProcessedFiles identifier check must be adjusted,
since the default value is an empty string for entries that
uses the original file.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sascha Rademacher +1
    • Oliver Klee +1
    • Markus Klein +1
    • Jörg Bösche +1
    • Oliver Hader +1
    • Christian Eßl +1
    • Benni Mack +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1719

  1. Florian Schuhmann uploaded patch set 1 12/05/19, 10:36

  2. TYPO3com voted on patch set 1 V +1 12/05/19, 10:52 Completed build in 09m 31s on Thu, 5 Dec, 10:52 AM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39103

  3. Oliver Klee commented on patch set 1 12/05/19, 11:20

    Is 9.5 affected as well?
  4. Florian Schuhmann commented on patch set 1 12/05/19, 11:31

    > Patch Set 1: > > (1 comment)

    Reply

    I think all versions since 7.3 are affected. So do I have to specify all versions?
  5. Oli Bartsch commented on patch set 1 12/05/19, 12:18

    Reply

    At least 9.5. Version 8.7 is in priority bugfix mode and as this is not really security relevant I don't think that will go into 8.7 so I would not add it. But the decision about such backports is always up to the core devs.
  6. Susi Moog updated the commit message in patch set 2 12/05/19, 12:32

  7. TYPO3com voted on patch set 2 V +1 12/05/19, 12:40 Completed build in 07m 18s on Thu, 5 Dec, 12:40 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39104

  8. Florian Schuhmann commented on patch set 2 12/05/19, 13:03

    Reply

    Done
  9. Benni Mack voted on patch set 2 CR +1 12/31/19, 13:25

  10. Oliver Klee commented on patch set 2 01/01/20, 11:14

    Can we have tests for this?
  11. Oliver Hader voted on patch set 2 CR +1 01/05/20, 17:16

  12. Steffen Frese voted on patch set 2 CR +1 01/15/20, 12:56

  13. Jörg Bösche voted on patch set 2 CR +1 01/16/20, 09:02

  14. Sascha Rademacher voted on patch set 2 CR +1 01/16/20, 09:06

  15. Christian Eßl voted on patch set 2 CR +1 02/26/20, 09:33

  16. Oliver Klee voted on patch set 2 CR +1 02/26/20, 10:16

  17. Markus Klein voted on patch set 2 V +1 CR +1 02/26/20, 10:35

  18. Georg Ringer voted on patch set 2 V +2 CR +2 02/26/20, 19:27

  19. Georg Ringer merged patch set 3 02/26/20, 19:27