Review main Merged

62539[TASK] Avoid controller methods on Fluid RenderingContext

Claus Due CR +2 V +2 Easy +6 −11 updated 12/15/19, 11:41

Commit message

The getter/setter methods related to controller name
and action name will be removed in Fluid 3.0.

An equally valid solution is to specify the template
path and filename, which also avoids the lookup
logic in Fluid from running and further increases the
failsafe operation of this controller.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Claus Due uploaded patch set 1 12/05/19, 13:51

  2. TYPO3com voted on patch set 1 V -1 12/05/19, 14:00 Completed build in 08m 17s on Thu, 5 Dec, 02:00 PM Test Summary: 290 of 69087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39105

  3. Mathias Brodala commented on patch set 1 CR -1 12/05/19, 15:28

    ErrorPageController.php:50

    Why not use setTemplateRootPaths() instead?

    ErrorPageController.php:51

    This must be "Error.html" instead.
  4. Claus Due uploaded patch set 2 12/05/19, 15:49

  5. Mathias Brodala commented on patch set 2 12/05/19, 15:50

    ErrorPageController.php:87

    If you keep using setTemplatePathAndFilename() above, then this should be dropped.
  6. Claus Due uploaded patch set 3 12/05/19, 15:56

  7. TYPO3com voted on patch set 2 V +1 12/05/19, 15:57 Completed build in 08m 01s on Thu, 5 Dec, 03:57 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39118

  8. TYPO3com voted on patch set 3 V +1 12/05/19, 16:04 Completed build in 07m 36s on Thu, 5 Dec, 04:04 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39119

  9. Claus Due commented on patch set 3 12/06/19, 12:47

    ErrorPageController.php:50 Reply Unresolved

    To avoid triggering the resolving logic, with the goal of making the controller even more failsafe.

    ErrorPageController.php:51 Reply

    Done

    ErrorPageController.php:87 Reply Unresolved

    True, it is now redundant.
  10. Mathias Brodala voted on patch set 3 CR +1 12/06/19, 13:32

  11. Alexander Schnitzler voted on patch set 3 V +1 CR +1 12/13/19, 14:23

  12. Oliver Klee voted on patch set 3 CR +1 12/13/19, 14:33

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 12/15/19, 11:41

  14. Daniel Goerz merged patch set 4 12/15/19, 11:41