62539[TASK] Avoid controller methods on Fluid RenderingContext
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Mathias Brodala +1
-
Verified V +2 Done
- Daniel Goerz +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Claus Due uploaded patch set 1 12/05/19, 13:51
-
TYPO3com voted on patch set 1 V -1 12/05/19, 14:00 Completed build in 08m 17s on Thu, 5 Dec, 02:00 PM Test Summary: 290 of 69087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39105
-
Mathias Brodala commented on patch set 1 CR -1 12/05/19, 15:28
ErrorPageController.php:51This must be "Error.html" instead. -
Claus Due uploaded patch set 2 12/05/19, 15:49
-
Mathias Brodala commented on patch set 2 12/05/19, 15:50
ErrorPageController.php:87If you keep using setTemplatePathAndFilename() above, then this should be dropped. -
Claus Due uploaded patch set 3 12/05/19, 15:56
-
TYPO3com voted on patch set 2 V +1 12/05/19, 15:57 Completed build in 08m 01s on Thu, 5 Dec, 03:57 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39118
-
TYPO3com voted on patch set 3 V +1 12/05/19, 16:04 Completed build in 07m 36s on Thu, 5 Dec, 04:04 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39119
-
Claus Due commented on patch set 3 12/06/19, 12:47
ErrorPageController.php:50Reply UnresolvedTo avoid triggering the resolving logic, with the goal of making the controller even more failsafe.ErrorPageController.php:51ReplyDoneErrorPageController.php:87Reply UnresolvedTrue, it is now redundant. -
Mathias Brodala voted on patch set 3 CR +1 12/06/19, 13:32
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 12/13/19, 14:23
-
Oliver Klee voted on patch set 3 CR +1 12/13/19, 14:33
-
Daniel Goerz voted on patch set 3 V +2 CR +2 12/15/19, 11:41
-
Daniel Goerz merged patch set 4 12/15/19, 11:41
ErrorPageController.php:50