Review main Merged

62540[BUGFIX] Check if header variable is set before using it

Susi Moog CR +2 V +2 Easy +1 −1 updated 12/06/19, 07:20

Commit message

Avoid a TypeError exception in NewContentElementController in
newer PHP versions because of an undefined array access.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Tobias D. +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Susi Moog uploaded patch set 1 12/05/19, 13:55

  2. Susi Moog updated the commit message in patch set 2 12/05/19, 13:56

  3. TYPO3com voted on patch set 1 V +1 12/05/19, 14:04 Completed build in 08m 38s on Thu, 5 Dec, 02:04 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39106

  4. TYPO3com voted on patch set 2 V +1 12/05/19, 14:06 Completed build in 10m 01s on Thu, 5 Dec, 02:06 PM Test Summary: 68636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39107

  5. Oli Bartsch commented on patch set 2 12/05/19, 14:39

    Worked for me. Just a nitpick in the commit message.
    I think this should be "is set". Otherwise I would suggest changing the sentence so it's clear that this is a function name and not a missing space. Maybe we should use "variable" instead of just "var". But thats just a personal feeling.
  6. Tobias D. voted on patch set 2 CR +1 12/05/19, 15:13

  7. Susi Moog commented on patch set 2 12/05/19, 15:21

    Reply Unresolved

    Feel free to adjust that :) Thanks!
  8. Oli Bartsch updated the commit message in patch set 3 12/05/19, 15:40

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 12/05/19, 15:40

  10. TYPO3com voted on patch set 3 V +1 12/05/19, 15:47 Completed build in 07m 17s on Thu, 5 Dec, 03:47 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39117

  11. Tobias D. voted on patch set 3 CR +1 12/05/19, 15:53

  12. Oliver Klee voted on patch set 3 CR +1 12/05/19, 18:07

  13. Benni Mack voted on patch set 3 V +2 CR +2 12/06/19, 07:20

  14. Benni Mack merged patch set 4 12/06/19, 07:20