Review main Merged

62541[TASK] Rename method getName of TypoScriptConstants VH

Claus Due CR +2 V +2 Easy +15 −15 updated 12/15/19, 16:07

Commit message

The name "getName" will be reserved in Fluid 3.0 and is
ambiguous. This patch renames that method to become
"getFieldName" which is less ambiguous and conflict free.

Additionally the ViewHelper is changed so it no longer
accesses deprecated property AbstractViewHelper->
viewHelperVariableContainer, instead accessing the
ViewHelperVariableContainer via $this->renderingContext.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Claus Due uploaded patch set 1 12/05/19, 13:59

  2. TYPO3com voted on patch set 1 V +1 12/05/19, 14:08 Completed build in 08m 42s on Thu, 5 Dec, 02:08 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39108

  3. Mathias Brodala voted on patch set 1 CR +1 12/05/19, 15:29

  4. Daniel Goerz voted on patch set 1 CR +1 12/15/19, 15:59

  5. Daniel Goerz voted on patch set 1 V +1 12/15/19, 16:06

  6. Susi Moog voted on patch set 1 V +1 CR +1 12/15/19, 16:06

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 12/15/19, 16:07

  8. Daniel Goerz merged patch set 2 12/15/19, 16:07