Review main Abandoned

62543[WIP][BUGFIX] Enum fields can be removed in database analyzer

Richard Haeser CR 0 V 0 Easy +7 −4 updated 11/11/21, 10:42

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 811

  1. Richard Haeser uploaded patch set 1 12/05/19, 14:32

  2. Richard Haeser commented on patch set 1 12/05/19, 14:33

    This patch only adds the tests to show it is not working as expected. Real patch has to be done
  3. TYPO3com voted on patch set 1 V -1 12/05/19, 14:39 Completed build in 07m 22s on Thu, 5 Dec, 02:39 PM Test Summary: 19 of 69087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39111

  4. Mathias Brodala commented on patch set 1 12/05/19, 15:32

    Should be "Keep enum fields on database schema update" AFAIS. The title of a commit should always describe what it does, not what was the problem before.
  5. Richard Haeser commented on patch set 1 12/05/19, 15:40

    Reply

    Thats why it states that it is possible to remove those fields (again). Now that is not possible. Keeping the fields is not the problem, the problem is when TYPO3 decides the field should be removed. But this patch is not ready for review as you can guess as it only contains the tests to show it is failing ;-)
  6. Mathias Brodala commented on patch set 1 12/05/19, 15:49

    Reply Unresolved

    Ah OK. Then Maybe "Make enum fields removable ..." I'm referring to https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html (imperative mood) here. :-)
  7. Benni Mack commented on patch set 1 04/06/20, 09:44

    ping
  8. Richard Haeser rebased onto patch set 2 03/25/21, 14:19

  9. TYPO3com voted on patch set 2 V -1 03/25/21, 14:27 Completed build in 07m 50s on Thu, 25 Mar, 02:27 PM Test Summary: 21 of 33448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10348

  10. core-ci voted on patch set 2 V -1 03/25/21, 14:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1835

  11. Benni Mack abandoned the change 11/11/21, 10:42

    no activity, will abandon this change, we can restore it later, once people want to pick it up again