Review main Merged

62544[BUGFIX] Fix keyboard behaviour on pagetree root node

Michael Telgkamp CR +2 V +2 Easy +10 −9 updated 12/06/19, 08:43

Commit message

- Do not toggle node with canToggle!==true
- Check if node has parent before trying to go to parent node

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 812

  1. Michael Telgkamp uploaded patch set 1 12/05/19, 14:55

  2. TYPO3com voted on patch set 1 V -1 12/05/19, 15:03 Completed build in 07m 39s on Thu, 5 Dec, 03:03 PM Test Summary: 68387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39112

  3. TYPO3com voted on patch set 1 V +1 12/05/19, 15:13 Completed build in 08m 02s on Thu, 5 Dec, 03:13 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39113

  4. Oli Bartsch commented on patch set 1 V +1 12/05/19, 22:55

    Thank you for the fast action on this.

    SvgTree.js:289

    maybe we could make `else if` here.
  5. Michael Telgkamp uploaded patch set 2 12/06/19, 07:56

  6. Michael Telgkamp commented on patch set 2 12/06/19, 07:57

    SvgTree.js:289 Reply

    I changed it to else if - thank you for the hint!
  7. Andreas Kienast uploaded patch set 3 12/06/19, 08:01

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 12/06/19, 08:02

  9. TYPO3com voted on patch set 2 V +1 12/06/19, 08:08 Completed build in 11m 28s on Fri, 6 Dec, 08:08 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39125

  10. TYPO3com voted on patch set 3 V +1 12/06/19, 08:14 Completed build in 12m 33s on Fri, 6 Dec, 08:14 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39127

  11. Susi Moog voted on patch set 3 V +2 CR +2 12/06/19, 08:43

  12. Susi Moog merged patch set 4 12/06/19, 08:43