62547[TASK] Speed up tests
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 40
- typo3/sysext/backend/Tests/Unit/Form/Element/InputHiddenElementTest.php3+5 −2
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+54 −45
- typo3/sysext/beuser/Tests/Unit/Service/ModuleDataStorageServiceTest.php+3 −3
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+17 −15
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+17 −16
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+23 −16
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+6 −7
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageServiceTest.php+3 −10
- typo3/sysext/core/Tests/Unit/Resource/Processing/ProcessorRegistryTest.php+19 −68
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+7 −8
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+11 −14
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php+62 −61
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+24 −25
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+37 −36
- typo3/sysext/extbase/Tests/Unit/Mvc/ResponseTest.php+18 −17
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+1 −2
Show 20 more files
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractCompositeValidatorTest.php+10 −10
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTest.php+10 −10
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+4 −3
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DownloadQueueTest.php+34 −40
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+176 −496
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+105 −209
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+198 −242
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.php+40 −30
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormViewHelperTest.php+8 −7
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+76 −79
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+11 −25
- typo3/sysext/form/Tests/Unit/Domain/Renderable/RenderableVariantTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php+12 −26
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+22 −41
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+4 −7
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+109 −121
- typo3/sysext/install/Tests/Unit/ViewHelpers/Format/PhpErrorCodeViewHelperTest.php+4 −3
- typo3/sysext/t3editor/Tests/Unit/Registry/AddonRegistryTest.php+6 −6
- typo3/sysext/t3editor/Tests/Unit/Registry/ModeRegistryTest.php+6 −6
Review log 2644
Show 1119 earlier messages
-
Benni Mack uploaded patch set 1 12/05/19, 18:58
-
TYPO3com voted on patch set 1 V -1 12/05/19, 19:05 Completed build in 07m 15s on Thu, 5 Dec, 07:05 PM Test Summary: 6 of 69087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39122
-
Benni Mack uploaded patch set 2 12/05/19, 19:12
-
TYPO3com voted on patch set 2 V -1 12/05/19, 19:19 Completed build in 07m 14s on Thu, 5 Dec, 07:19 PM Test Summary: 6 of 68831 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39123
-
Susi Moog commented on patch set 2 12/05/19, 19:20
another easy one would be mocks of `\TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\Form\Fixtures\ExtendsAbstractEntity`, of `\TYPO3\CMS\Extensionmanager\Domain\Model\Dependency::class`, `\TYPO3\CMS\Extensionmanager\Domain\Model\Extension::class"` and `\TYPO3\CMS\Extensionmanager\Domain\Model\DownloadQueue::class"` (don't want to push in between your work, but those should be fairly easy to get rid of) -
Susi Moog uploaded patch set 3 12/07/19, 08:23
-
TYPO3com voted on patch set 3 V +1 12/07/19, 08:31 Completed build in 07m 31s on Sat, 7 Dec, 08:31 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39236
-
Susi Moog uploaded patch set 4 12/07/19, 16:15
-
Susi Moog commented on patch set 4 12/07/19, 16:16
Rewrote the ExtensionManagementServiceTests as they were rly ugly. -
TYPO3com voted on patch set 4 V +1 12/07/19, 16:23 Completed build in 07m 38s on Sat, 7 Dec, 04:23 PM Test Summary: 68702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39244
-
Susi Moog uploaded patch set 5 12/07/19, 16:40
-
TYPO3com voted on patch set 5 V +1 12/07/19, 16:48 Completed build in 07m 54s on Sat, 7 Dec, 04:48 PM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39245
-
Susi Moog uploaded patch set 6 12/08/19, 08:19
-
TYPO3com voted on patch set 6 V -1 12/08/19, 08:34 Completed build in 14m 06s on Sun, 8 Dec, 08:34 AM Test Summary: 68590 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39256
-
TYPO3com voted on patch set 6 V +1 12/08/19, 08:36 Completed build in 29m 56s on Sun, 8 Dec, 08:36 AM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39256
-
Susi Moog uploaded patch set 7 12/08/19, 09:01
-
TYPO3com voted on patch set 7 V +1 12/08/19, 09:08 Completed build in 06m 47s on Sun, 8 Dec, 09:08 AM Test Summary: 68672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39259
-
Alexander Schnitzler commented on patch set 7 12/08/19, 09:12
InputHiddenElementTest.php:39Just a question out of interest. When did we decide to introduce prophecy and what problem does it solve that native phpunit mocks do not? I see more and more prophecy being used and I don't see a reason to use that library at all. -
Susi Moog commented on patch set 7 12/08/19, 09:22
InputHiddenElementTest.php:39Replyehm. it's part of phpunit by default - it was integrated quite some time ago ;) no extra library necessary at all. in addition: it's a lot stricter in what and how it allows to mock and forces you to think more about public API vs. internal call stacks.
-
Susi Moog commented on patch set 7 12/08/19, 09:24
-
Alexander Schnitzler commented on patch set 7 12/08/19, 09:29
> Patch Set 7: > > https://phpunit.de/manual/6.5/en/test-doubles.html#test-doubles.prophecy fyi.InputHiddenElementTest.php:39Reply UnresolvedOh, didn't know that. ^^ Thanks for the clarification. -
Susi Moog uploaded patch set 8 12/09/19, 19:17
-
TYPO3com voted on patch set 8 V +1 12/09/19, 19:25 Completed build in 07m 56s on Mon, 9 Dec, 07:25 PM Test Summary: 68672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39294
-
Oliver Hader voted on patch set 8 CR +1 12/10/19, 11:38
-
Susi Moog uploaded patch set 9 12/15/19, 08:10
-
TYPO3com voted on patch set 9 V +1 12/15/19, 08:20 Completed build in 09m 24s on Sun, 15 Dec, 08:20 AM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39428
-
Susi Moog uploaded patch set 10 12/15/19, 08:32
-
TYPO3com voted on patch set 10 V +1 12/15/19, 08:42 Completed build in 09m 53s on Sun, 15 Dec, 08:42 AM Test Summary: 68666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39429
-
Susi Moog uploaded patch set 11 12/15/19, 09:21
-
TYPO3com voted on patch set 11 V -1 12/15/19, 09:29 Completed build in 07m 54s on Sun, 15 Dec, 09:29 AM Test Summary: 18 of 68856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39430
-
Susi Moog uploaded patch set 12 12/15/19, 13:56
-
TYPO3com voted on patch set 12 V -1 12/15/19, 13:57 Completed build in 22s on Sun, 15 Dec, 01:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39433
-
Susi Moog commented on patch set 13 12/15/19, 14:38
Published edit on patch set 12. -
TYPO3com voted on patch set 13 V +1 12/15/19, 14:47 Completed build in 08m 33s on Sun, 15 Dec, 02:47 PM Test Summary: 68666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39434
-
Susi Moog uploaded patch set 14 12/17/19, 11:55
-
Susi Moog commented on patch set 14 12/17/19, 11:57
(that's it from my side, picked the easy ones from all extensions - there is more possible however we'd need to rewrite a lot of tests completely) -
TYPO3com voted on patch set 14 V -1 12/17/19, 12:03 Completed build in 07m 46s on Tue, 17 Dec, 12:03 PM Test Summary: 69241 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39483
-
TYPO3com voted on patch set 14 V +1 12/17/19, 12:19 Completed build in 31m 32s on Tue, 17 Dec, 12:19 PM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39483
-
Susi Moog updated the commit message in patch set 15 12/17/19, 12:21
-
TYPO3com voted on patch set 15 V -1 12/17/19, 12:29 Completed build in 07m 31s on Tue, 17 Dec, 12:29 PM Test Summary: 69238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39484
-
TYPO3com voted on patch set 15 V +1 12/17/19, 12:44 Completed build in 29m 44s on Tue, 17 Dec, 12:44 PM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39484
-
Benni Mack voted on patch set 15 V +1 CR +1 12/17/19, 16:31
-
Anja Leichsenring voted on patch set 15 V +2 CR +2 12/18/19, 11:36
-
Anja Leichsenring merged patch set 16 12/18/19, 11:36