Review main Merged

62547[TASK] Speed up tests

Benni Mack CR +2 V +2 Nightmare +1158 −1722 updated 12/18/19, 11:36

Commit message

Some tests use "accessibleMock" (= eval() code) where
it is completely unnecessary as not even a mock is needed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 40

Show 20 more files

Review log 2644

Show 1119 earlier messages
  1. Benni Mack uploaded patch set 1 12/05/19, 18:58

  2. TYPO3com voted on patch set 1 V -1 12/05/19, 19:05 Completed build in 07m 15s on Thu, 5 Dec, 07:05 PM Test Summary: 6 of 69087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39122

  3. Benni Mack uploaded patch set 2 12/05/19, 19:12

  4. TYPO3com voted on patch set 2 V -1 12/05/19, 19:19 Completed build in 07m 14s on Thu, 5 Dec, 07:19 PM Test Summary: 6 of 68831 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39123

  5. Susi Moog commented on patch set 2 12/05/19, 19:20

    another easy one would be mocks of `\TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\Form\Fixtures\ExtendsAbstractEntity`, of `\TYPO3\CMS\Extensionmanager\Domain\Model\Dependency::class`, `\TYPO3\CMS\Extensionmanager\Domain\Model\Extension::class"` and `\TYPO3\CMS\Extensionmanager\Domain\Model\DownloadQueue::class"` (don't want to push in between your work, but those should be fairly easy to get rid of)
  6. Susi Moog uploaded patch set 3 12/07/19, 08:23

  7. TYPO3com voted on patch set 3 V +1 12/07/19, 08:31 Completed build in 07m 31s on Sat, 7 Dec, 08:31 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39236

  8. Susi Moog uploaded patch set 4 12/07/19, 16:15

  9. Susi Moog commented on patch set 4 12/07/19, 16:16

    Rewrote the ExtensionManagementServiceTests as they were rly ugly.
  10. TYPO3com voted on patch set 4 V +1 12/07/19, 16:23 Completed build in 07m 38s on Sat, 7 Dec, 04:23 PM Test Summary: 68702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39244

  11. Susi Moog uploaded patch set 5 12/07/19, 16:40

  12. TYPO3com voted on patch set 5 V +1 12/07/19, 16:48 Completed build in 07m 54s on Sat, 7 Dec, 04:48 PM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39245

  13. Susi Moog uploaded patch set 6 12/08/19, 08:19

  14. TYPO3com voted on patch set 6 V -1 12/08/19, 08:34 Completed build in 14m 06s on Sun, 8 Dec, 08:34 AM Test Summary: 68590 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39256

  15. TYPO3com voted on patch set 6 V +1 12/08/19, 08:36 Completed build in 29m 56s on Sun, 8 Dec, 08:36 AM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39256

  16. Susi Moog uploaded patch set 7 12/08/19, 09:01

  17. TYPO3com voted on patch set 7 V +1 12/08/19, 09:08 Completed build in 06m 47s on Sun, 8 Dec, 09:08 AM Test Summary: 68672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39259

  18. Alexander Schnitzler commented on patch set 7 12/08/19, 09:12

    InputHiddenElementTest.php:39

    Just a question out of interest. When did we decide to introduce prophecy and what problem does it solve that native phpunit mocks do not? I see more and more prophecy being used and I don't see a reason to use that library at all.
  19. Susi Moog commented on patch set 7 12/08/19, 09:22

    InputHiddenElementTest.php:39 Reply

    ehm. it's part of phpunit by default - it was integrated quite some time ago ;) no extra library necessary at all. in addition: it's a lot stricter in what and how it allows to mock and forces you to think more about public API vs. internal call stacks.
  1. Susi Moog commented on patch set 7 12/08/19, 09:24

  2. Alexander Schnitzler commented on patch set 7 12/08/19, 09:29

    InputHiddenElementTest.php:39 Reply Unresolved

    Oh, didn't know that. ^^ Thanks for the clarification.
  3. Susi Moog uploaded patch set 8 12/09/19, 19:17

  4. TYPO3com voted on patch set 8 V +1 12/09/19, 19:25 Completed build in 07m 56s on Mon, 9 Dec, 07:25 PM Test Summary: 68672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39294

  5. Oliver Hader voted on patch set 8 CR +1 12/10/19, 11:38

  6. Susi Moog uploaded patch set 9 12/15/19, 08:10

  7. TYPO3com voted on patch set 9 V +1 12/15/19, 08:20 Completed build in 09m 24s on Sun, 15 Dec, 08:20 AM Test Summary: 68678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39428

  8. Susi Moog uploaded patch set 10 12/15/19, 08:32

  9. TYPO3com voted on patch set 10 V +1 12/15/19, 08:42 Completed build in 09m 53s on Sun, 15 Dec, 08:42 AM Test Summary: 68666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39429

  10. Susi Moog uploaded patch set 11 12/15/19, 09:21

  11. TYPO3com voted on patch set 11 V -1 12/15/19, 09:29 Completed build in 07m 54s on Sun, 15 Dec, 09:29 AM Test Summary: 18 of 68856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39430

  12. Susi Moog uploaded patch set 12 12/15/19, 13:56

  13. TYPO3com voted on patch set 12 V -1 12/15/19, 13:57 Completed build in 22s on Sun, 15 Dec, 01:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39433

  14. Susi Moog commented on patch set 13 12/15/19, 14:38

    Published edit on patch set 12.
  15. TYPO3com voted on patch set 13 V +1 12/15/19, 14:47 Completed build in 08m 33s on Sun, 15 Dec, 02:47 PM Test Summary: 68666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39434

  16. Susi Moog uploaded patch set 14 12/17/19, 11:55

  17. Susi Moog commented on patch set 14 12/17/19, 11:57

    (that's it from my side, picked the easy ones from all extensions - there is more possible however we'd need to rewrite a lot of tests completely)
  18. TYPO3com voted on patch set 14 V -1 12/17/19, 12:03 Completed build in 07m 46s on Tue, 17 Dec, 12:03 PM Test Summary: 69241 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39483

  19. TYPO3com voted on patch set 14 V +1 12/17/19, 12:19 Completed build in 31m 32s on Tue, 17 Dec, 12:19 PM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39483

  20. Susi Moog updated the commit message in patch set 15 12/17/19, 12:21

  21. TYPO3com voted on patch set 15 V -1 12/17/19, 12:29 Completed build in 07m 31s on Tue, 17 Dec, 12:29 PM Test Summary: 69238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39484

  22. TYPO3com voted on patch set 15 V +1 12/17/19, 12:44 Completed build in 29m 44s on Tue, 17 Dec, 12:44 PM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39484

  23. Benni Mack voted on patch set 15 V +1 CR +1 12/17/19, 16:31

  24. Anja Leichsenring voted on patch set 15 V +2 CR +2 12/18/19, 11:36

  25. Anja Leichsenring merged patch set 16 12/18/19, 11:36