Review 9.5 Merged

62548[BUGFIX] Add support for options in "Execute console commands"

Sebastian Mazza CR +2 V +2 Normal +199 −10 updated 01/16/20, 13:31

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1216

  1. Sebastian Mazza uploaded patch set 1 12/06/19, 00:18

  2. TYPO3com voted on patch set 1 V -1 12/06/19, 00:19 Completed build in 18s on Fri, 6 Dec, 12:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1668

  3. Sebastian Mazza uploaded patch set 2 12/06/19, 00:36

  4. TYPO3com voted on patch set 2 V +1 12/06/19, 00:46 Completed build in 10m 29s on Fri, 6 Dec, 12:46 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1669

  5. Richard Haeser commented on patch set 2 12/06/19, 04:53

    Unresolved

    Wrong issue number I guess ;-)
  6. Sebastian Mazza commented on patch set 2 12/06/19, 11:50

    > Patch Set 2: > > (1 comment) You are right! The issue number should be #86917.
  7. Sebastian Mazza updated the commit message in patch set 3 12/06/19, 11:51

  8. TYPO3com voted on patch set 3 V +1 12/06/19, 12:00 Completed build in 09m 02s on Fri, 6 Dec, 12:00 PM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1681

  9. Susi Moog commented on patch set 3 CR -2 12/06/19, 15:01

    We need to take care of master first. Backports (to branches other than master) should only be done after the master patch is finished.
  10. Daniel Goerz abandoned the change 01/16/20, 09:47

    We backport after merging the master patch
  11. Daniel Goerz restored the change 01/16/20, 12:42

  12. Daniel Goerz uploaded patch set 4 01/16/20, 12:42

  13. Susi Moog wrote 01/16/20, 12:43

    Removed Code-Review-2 by Susanne Moog <look@susi.dev>
  14. TYPO3com voted on patch set 4 V +1 01/16/20, 13:00 Completed build in 17m 03s on Thu, 16 Jan, 01:00 PM Test Summary: 73106 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1862

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 01/16/20, 13:31

  16. Daniel Goerz merged patch set 5 01/16/20, 13:31