Review main Merged

62551Revert "[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable"

Benjamin Franzke CR +2 V +2 Easy +2 −4 updated 12/06/19, 11:38

Commit message

This reverts commit 26c9a8e32637d506249989318941c923171b7658.

The schedulers *primary* task is to *schedule* tasks, not to execute them
from the backend. The backend-execution is only an additional
functionality, which is available because it's sometime handy for manual
tasks/testing.

We shouldn't mark commands as non-schedulable when scheduling them is a
perectly valid usecase.
Usecases for scheduling backend locks are:
* Planned maintenance locks:
  schedule a backend lock for a planned update or migration where you
  agreed to stop editing as of a certain date.
* Regular edit-locks, e.g.:
  schedule a backend lock for let's say every friday as of 8pm
  schedule backend unlock on mondays at 8am.

The reverted patch tried to fix the situation where the lock task was
executed from the backend scheduler overview. If we'd want to fix that,
the proper fix would be to add another property which states that this
command must not be executed from the backend.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Benjamin Franzke uploaded patch set 1 12/06/19, 09:16

  2. TYPO3com voted on patch set 1 V +1 12/06/19, 09:24 Completed build in 07m 48s on Fri, 6 Dec, 09:24 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39135

  3. Markus Klein commented on patch set 1 V +1 CR +1 12/06/19, 09:41

    Okay, fair enough a good and valid use case
  4. Frank Nägler commented on patch set 1 CR -1 12/06/19, 09:49

    The reverts line is missing, please follow to the revert workflow: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/HandlingAPatch/Revert.html
  5. Benjamin Franzke updated the commit message in patch set 2 12/06/19, 09:52

  6. Benjamin Franzke commented on patch set 2 12/06/19, 09:56

    > The reverts line is missing, please follow to the revert workflow: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/HandlingAPatch/Revert.html Thank you, I fixed the line and set the original ticket to "Accepted".
  7. TYPO3com voted on patch set 2 V -1 12/06/19, 10:00 Completed build in 07m 40s on Fri, 6 Dec, 10:00 AM Test Summary: 68504 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39140

  8. TYPO3com voted on patch set 2 V +1 12/06/19, 10:11 Completed build in 07m 13s on Fri, 6 Dec, 10:11 AM Test Summary: 68762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39141

  9. Frank Nägler commented on patch set 2 V +1 CR +1 12/06/19, 10:30

    > Patch Set 2: > > > The reverts line is missing, please follow to the revert workflow: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/HandlingAPatch/Revert.html > > Thank you, I fixed the line and set the original ticket to "Accepted". thanks, looks good now.
  10. Markus Klein voted on patch set 2 V +1 CR +1 12/06/19, 11:03

  11. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/06/19, 11:38

  12. Benjamin Franzke merged patch set 3 12/06/19, 11:38