62552[BUGFIX] Fix wrong language parameters in language menu shortcut links
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 4
- Bug #89871HrefLangGenerator: Wrong links generated with page translations that use a shortcut
- Bug #81657TSFE->page contains default language page when content_fallback; 1,0 is used
- Bug #86595No Language Fallback
- Bug #19114sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content
Files 3
Review log 2436
Show 711 earlier messages
-
Christian Eßl uploaded patch set 1 12/06/19, 09:24
-
Christian Eßl commented on patch set 1 12/06/19, 09:25
Added you as a reviewer because the commit that introduced the bug appears to come from you: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676 -
Mathias Brodala updated the commit message in patch set 2 12/06/19, 09:31
-
TYPO3com voted on patch set 1 V +1 12/06/19, 09:34 Completed build in 10m 09s on Fri, 6 Dec, 09:34 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39137
-
TYPO3com voted on patch set 2 V +1 12/06/19, 09:39 Completed build in 07m 45s on Fri, 6 Dec, 09:39 AM Test Summary: 68762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39138
-
Benni Mack commented on patch set 2 12/31/19, 13:22
AbstractMenuContentObject.php:1362shouldn't the $shortcut contain things like '_PAGES_OVERLAY_REQUESTEDLANGUAGE' and '_PAGES_OVERLAY_LANGUAGE' that would be the already resolved information? -
Christian Eßl uploaded patch set 3 02/19/20, 18:05
-
TYPO3com voted on patch set 3 V -1 02/19/20, 18:18 Completed build in 13m 34s on Wed, 19 Feb, 06:18 PM Test Summary: 3 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-318
-
Christian Eßl uploaded patch set 4 02/19/20, 19:38
-
Wolfgang Klinger updated the commit message in patch set 5 02/19/20, 19:46
-
TYPO3com voted on patch set 4 V +1 02/19/20, 19:58 Completed build in 15m 47s on Wed, 19 Feb, 07:58 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-326
-
TYPO3com voted on patch set 5 V +1 02/19/20, 20:10 Completed build in 22m 17s on Wed, 19 Feb, 08:10 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-328
-
Benni Mack voted on patch set 5 CR +1 03/07/20, 11:31
-
Benni Mack commented on patch set 5 03/07/20, 11:32
I think we could easily add this into one of the SiteHandlingLink Scenario functional tests in EXT:frontend -
Christian Eßl marked it work in progress 03/09/20, 11:56
-
Christian Eßl commented on patch set 5 03/09/20, 12:00
> Patch Set 5: > > I think we could easily add this into one of the SiteHandlingLink Scenario functional tests in EXT:frontend I agree. I'll add a test later, as this a somewhat unusual edge case. :) -
Christian Eßl marked it work in progress 03/09/20, 12:00
-
Christian Eßl uploaded patch set 6 03/10/20, 17:00
-
TYPO3com voted on patch set 6 V -1 03/10/20, 17:11 Completed build in 10m 26s on Tue, 10 Mar, 05:11 PM Test Summary: 3 of 61915 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1223
-
Benni Mack commented on patch set 6 05/04/20, 07:25
This change is ready for review.AbstractMenuContentObject.php:1365sounds like a "??" comparison -
Benni Mack uploaded patch set 7 05/04/20, 09:18
-
TYPO3com voted on patch set 7 V -1 05/04/20, 09:31 Completed build in 12m 33s on Mon, 4 May, 09:31 AM Test Summary: 3 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3182
-
Benni Mack updated the commit message in patch set 8 05/25/20, 18:50
-
TYPO3com voted on patch set 8 V -1 05/25/20, 20:17 Completed build in 41m 46s on Mon, 25 May, 08:17 PM Test Summary: 3 of 74292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3544
-
TYPO3com commented on patch set 8 08/28/20, 12:29 Completed build in 11m 39s on Fri, 28 Aug, 12:29 PM Test Summary: 3 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5028
-
TYPO3com commented on patch set 8 01/07/21, 03:22 Completed build in 10m 32s on Thu, 7 Jan, 03:22 AM Test Summary: 3 of 32806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8716
-
Richard Haeser commented on patch set 8 01/07/21, 12:22
Strange thing with the failing test. I'm on it to investigate. -
Richard Haeser uploaded patch set 9 01/08/21, 13:04
-
TYPO3com voted on patch set 9 V +1 01/08/21, 13:15 Completed build in 10m 23s on Fri, 8 Jan, 01:15 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8761
-
Richard Haeser voted on patch set 9 V +1 CR +1 01/08/21, 13:15
-
Richard Haeser uploaded patch set 10 01/09/21, 23:42
-
Richard Haeser commented on patch set 10 V +1 CR +1 01/09/21, 23:43
Removed 9.5 as this is an edge-case and is not a priority bugfix if you ask me. -
TYPO3com voted on patch set 10 V +1 01/09/21, 23:52 Completed build in 10m 20s on Sat, 9 Jan, 11:52 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8784
-
Richard Haeser commented on patch set 10 02/04/21, 13:51
AbstractMenuContentObject.php:1362ReplyDoneAbstractMenuContentObject.php:1365ReplyDone -
Benni Mack voted on patch set 10 V +2 CR +2 02/10/21, 09:33
-
Benni Mack merged patch set 11 02/10/21, 09:33