Review main Merged

62559[BUGFIX] Disable lockIP by default

Rasmus Larsen CR +2 V +2 Easy +37 −12 updated 12/10/19, 11:04

Commit message

IPLock breaks modern IPv6 setups because of the Fast fallback
aka. Happy Eyeballs algorithm that can cause users to jump between
IPv4 and IPv6 arbitrarily.
Enabling lockIP should be a very conscious decision, not a default.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2436

Show 711 earlier messages
  1. Rasmus Larsen uploaded patch set 1 12/06/19, 13:09

  2. TYPO3com voted on patch set 1 V -1 12/06/19, 13:16 Completed build in 07m 35s on Fri, 6 Dec, 01:16 PM Test Summary: 68497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39158

  3. Rasmus Larsen commented on patch set 1 12/06/19, 13:20

    This disable IPLock by default. The reasoning is outlined in the linked issue, but it comes down to: - IPLock breaks IPv6 because of the "Happy Eyeballs" algorithm. https://en.wikipedia.org/wiki/Happy_Eyeballs - IPLock is mostly made moot by the adoption of nearly universal/freely SSL/TLS Certificates. - If someone is able to intercept the users traffic, they can probably also control the users IP address. Basically this was a security feature for another time, at this point Typo3 in its default setup breaks when IPv6 is used.
  4. Markus Klein updated the commit message in patch set 2 12/06/19, 17:10

  5. TYPO3com voted on patch set 2 V +1 12/06/19, 17:17 Completed build in 07m 01s on Fri, 6 Dec, 05:17 PM Test Summary: 68730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39193

  6. Georg Ringer commented on patch set 2 12/06/19, 20:05

    can we have an important.rst for that?
  7. Rasmus Larsen uploaded patch set 3 12/07/19, 06:38

  8. TYPO3com voted on patch set 3 V +1 12/07/19, 06:54 Completed build in 15m 30s on Sat, 7 Dec, 06:54 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39235

  9. Rasmus Larsen commented on patch set 3 12/07/19, 08:25

    > Patch Set 2: > > can we have an important.rst for that? Yes, added that, and aside from that I believe updating the documentation is probably the most important thing. But I guess that's in a different repository (Typo3 explained) right? And I guess we should go through the approval process for this one first? https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/Security/GuidelinesIntegrators/Index.html?highlight=lockip#lockip-lockipv6 Also, if it were up to me, which it most certainly isn't, I would suggest deprecating the entire LockIP feature in 10.3 and suggesting that anyone who somehow feel that it's essential to them, implement it as an extension. I'm in no way against keeping the feature in core, I just think it will cause a lot of confusion and user issues going forward as ipv6 usage becomes more and more prevalent and people start experiencing these, non trivial to debug, session issues.
  10. Oli Bartsch updated the commit message in patch set 4 12/07/19, 11:28

  11. TYPO3com voted on patch set 4 V -1 12/07/19, 11:36 Completed build in 07m 31s on Sat, 7 Dec, 11:36 AM Test Summary: 68449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39238

  1. Oli Bartsch commented on patch set 4 CR -1 12/07/19, 11:39

    Important-89869-ChangeLockIpDefaultToDisabled.rst:1 Unresolved

    Could you please add proper line breakes to the rst. Also the format of the title seems to be not valid.
  2. TYPO3com voted on patch set 4 V +1 12/07/19, 11:50 Completed build in 07m 21s on Sat, 7 Dec, 11:50 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39239

  3. Rasmus Larsen uploaded patch set 5 12/07/19, 15:17

  4. TYPO3com voted on patch set 5 V -1 12/07/19, 15:24 Completed build in 06m 58s on Sat, 7 Dec, 03:24 PM Test Summary: 68451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39240

  5. Rasmus Larsen uploaded patch set 6 12/07/19, 15:30

  6. Rasmus Larsen uploaded patch set 7 12/07/19, 15:34

  7. TYPO3com commented on patch set 6 12/07/19, 15:38 Completed build in 07m 57s on Sat, 7 Dec, 03:38 PM Test Summary: 68449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39241

  8. Rasmus Larsen uploaded patch set 8 12/07/19, 15:40

  9. TYPO3com voted on patch set 7 V -1 12/07/19, 15:43 Completed build in 08m 25s on Sat, 7 Dec, 03:43 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39242

  10. TYPO3com voted on patch set 8 V +1 12/07/19, 15:47 Completed build in 07m 18s on Sat, 7 Dec, 03:47 PM Test Summary: 68707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39243

  11. Markus Klein commented on patch set 8 12/07/19, 16:47

    Important-89869-ChangeLockIpDefaultToDisabled.rst:20 Unresolved

    I prefer consistent naming of IPv6 as this is an abbreviation
  12. Markus Klein commented on patch set 9 12/07/19, 16:49

    Published edit on patch set 8.
  13. Markus Klein voted on patch set 9 V +1 CR +1 12/07/19, 16:50

  14. Markus Klein commented on patch set 9 V 0 CR -1 12/07/19, 16:51

    we need to fix DefaultConfigrationDescription.yaml too on it
  15. Markus Klein uploaded patch set 10 12/07/19, 16:53

  16. Markus Klein updated the commit message in patch set 11 12/07/19, 16:54

  17. Markus Klein commented on patch set 11 V +1 CR +1 12/07/19, 16:54

    now I'm fine with the change
  18. TYPO3com voted on patch set 9 V +1 12/07/19, 16:57 Completed build in 08m 02s on Sat, 7 Dec, 04:57 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39246

  19. TYPO3com voted on patch set 10 V +1 12/07/19, 17:02 Completed build in 08m 56s on Sat, 7 Dec, 05:02 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39247

  20. TYPO3com voted on patch set 11 V +1 12/07/19, 17:05 Completed build in 09m 01s on Sat, 7 Dec, 05:05 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39248

  21. Georg Ringer voted on patch set 11 V +1 CR +1 12/09/19, 09:23

  22. Alexander Schnitzler voted on patch set 11 V +1 CR +1 12/09/19, 09:41

  23. Oli Bartsch voted on patch set 11 CR +1 12/09/19, 09:51

  24. Benni Mack voted on patch set 11 V +2 CR +2 12/10/19, 11:04

  25. Benni Mack merged patch set 12 12/10/19, 11:04