Review main Merged

62576[BUGFIX] Supply origin to URL if domain is missing

Andreas Kienast CR +2 V +2 Normal +54 −7 updated 12/11/19, 08:46

Commit message

The AJAX API fails to send a request if the API receives a non-absolute
URL like /typo3/index.php?foo=bar, since the domain is missing. To fix
this issue, the origin of the triggering request is added as well as
`base` argument of URL().

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1118

  1. Andreas Kienast uploaded patch set 1 12/06/19, 22:17

  2. TYPO3com voted on patch set 1 V +1 12/06/19, 22:26 Completed build in 09m 11s on Fri, 6 Dec, 10:26 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39233

  3. Susi Moog commented on patch set 1 12/07/19, 07:01

    maybe I'm overlookin something, but shouldn't we also have tests for relative URLs then?
  4. Andreas Kienast commented on patch set 1 12/07/19, 07:16

    > Patch Set 1: > > maybe I'm overlookin something, but shouldn't we also have tests for relative URLs then? Yes. It just was late yesterday and forgot them, I'll try to add them somewhen today.
  5. Andreas Kienast uploaded patch set 2 12/07/19, 10:55

  6. TYPO3com voted on patch set 2 V -1 12/07/19, 11:02 Completed build in 06m 56s on Sat, 7 Dec, 11:02 AM Test Summary: 68620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39237

  7. TYPO3com voted on patch set 2 V +1 12/07/19, 11:16 Completed build in 27m 52s on Sat, 7 Dec, 11:16 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39237

  8. Andreas Kienast uploaded patch set 3 12/08/19, 08:37

  9. TYPO3com voted on patch set 3 V -1 12/08/19, 08:45 Completed build in 08m 15s on Sun, 8 Dec, 08:45 AM Test Summary: 1 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39257

  10. TYPO3com voted on patch set 3 V +1 12/09/19, 09:32 Completed build in 1h 03m 27s on Mon, 9 Dec, 09:32 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39257

  11. Susi Moog voted on patch set 3 V +1 CR +1 12/11/19, 06:06

  12. Andreas Kienast commented on patch set 3 CR -1 12/11/19, 07:42

    Will check something else with URI()
  13. Andreas Kienast uploaded patch set 4 12/11/19, 08:14

  14. Susi Moog voted on patch set 4 V +1 CR +1 12/11/19, 08:36

  15. Frank Nägler voted on patch set 4 V +2 CR +2 12/11/19, 08:38

  16. TYPO3com voted on patch set 4 V -1 12/11/19, 08:39 Completed build in 25m 04s on Wed, 11 Dec, 08:39 AM Test Summary: 1 of 69164 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39323

  17. TYPO3com voted on patch set 4 V +1 12/11/19, 08:42 Completed build in 53m 11s on Wed, 11 Dec, 08:42 AM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39323

  18. Frank Nägler merged patch set 5 12/11/19, 08:46