Review main Merged

62578[TASK] Use AJAX API in top toolbar items

Andreas Kienast CR +2 V +2 Normal +86 −122 updated 12/12/19, 19:27

Commit message

The top toolbar items now use our AJAX API instead of $.ajax().

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1924

  1. Andreas Kienast uploaded patch set 1 12/08/19, 08:37

  2. Andreas Kienast commented on patch set 1 CR -2 12/08/19, 08:37

  3. TYPO3com voted on patch set 1 V -1 12/08/19, 08:48 Completed build in 10m 52s on Sun, 8 Dec, 08:48 AM Test Summary: 63 of 69068 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39258

  4. Andreas Kienast uploaded patch set 2 12/11/19, 08:48

  5. Andreas Kienast voted on patch set 2 CR 0 12/11/19, 08:48

  6. TYPO3com voted on patch set 2 V +1 12/11/19, 09:24 Completed build in 35m 21s on Wed, 11 Dec, 09:24 AM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39325

  7. Oli Bartsch commented on patch set 2 CR -1 12/11/19, 18:42

    ClearCacheMenu.ts:78

    Why did you remove the labels again? (Added recently in https://review.typo3.org/c/Packages/TYPO3.CMS/+/62269)
  8. Andreas Kienast commented on patch set 2 12/11/19, 19:03

    ClearCacheMenu.ts:78 Reply Unresolved

    Sorry, rebase fail
  9. Andreas Kienast uploaded patch set 3 12/11/19, 19:08

  10. TYPO3com voted on patch set 3 V -1 12/11/19, 19:29 Completed build in 20m 48s on Wed, 11 Dec, 07:29 PM Test Summary: 68423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39347

  11. TYPO3com voted on patch set 3 V +1 12/11/19, 19:33 Completed build in 45m 29s on Wed, 11 Dec, 07:33 PM Test Summary: 68716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39347

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 12/11/19, 20:06

  13. Georg Ringer commented on patch set 3 CR -1 12/12/19, 04:04

    ClearCacheMenu.ts:68

    Why switching from get to post?

    SystemInformationMenu.ts:75 Unresolved

    Why now get?
  14. Andreas Kienast commented on patch set 3 12/12/19, 04:47

    ClearCacheMenu.ts:68 Reply

    Because post makes no sense as no data is sent
  15. Andreas Kienast commented on patch set 3 12/12/19, 05:21

    ClearCacheMenu.ts:68 Reply

    Btw, we're switching from post to get...
  16. Georg Ringer voted on patch set 3 CR 0 12/12/19, 07:44

  17. Oli Bartsch commented on patch set 3 V -1 12/12/19, 09:02

    ClearCacheMenu.ts:68 Reply

    Ah good catch Georg, overlooked this yesterday. The choice between get and post is not whether there are arguments submitted but rather if the state of the server is changed. Therefore this should be post because the cache is cleared.
  18. Andreas Kienast commented on patch set 3 12/12/19, 09:15

    ClearCacheMenu.ts:68 Reply

    Since we're removing caches, this would be technically a DELETE request. Anyway, I don't care that much which type of request we send, tbh.
  19. Oli Bartsch commented on patch set 3 12/12/19, 12:08

    ClearCacheMenu.ts:68 Reply Unresolved

    This is no DELETE request because a DELETE request will delete some resource on the server which results in the resource is not accessible anymore (404). Just "clearing" the cache is POST with in this case no further data supplied. Properly speaking it's neither a POST nor a DELETE but as DELETED is defined as: "The DELETE method requests that the origin server delete the resource identified by the Request-URI." So only POST remains. Because we just want to switch from jQuery to the AJAX Api we should let the the types as they are.
  20. Andreas Kienast uploaded patch set 4 12/12/19, 12:54

  21. Oli Bartsch voted on patch set 4 V +1 CR +1 12/12/19, 13:31

  22. TYPO3com voted on patch set 4 V +1 12/12/19, 13:48 Completed build in 53m 49s on Thu, 12 Dec, 01:48 PM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39361

  23. Daniel Goerz voted on patch set 4 V +2 CR +2 12/12/19, 19:26

  24. Daniel Goerz merged patch set 5 12/12/19, 19:27