62579[TASK] Make Extbase Request PSR-7 compatible
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 8
- typo3/sysext/core/Classes/Utility/ClassNamingUtility.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Web/ReferringRequest.php+5 −1
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+19 −10
- typo3/sysext/extbase/Classes/Mvc/Request.php+286 −144
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php+46 −39
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+0 −60
- typo3/sysext/fluid/Classes/View/StandaloneView.php+4 −1
Review log 1527
Show 12 earlier messages
-
Alexander Schnitzler uploaded patch set 1 12/08/19, 13:48
-
TYPO3com voted on patch set 1 V -1 12/08/19, 13:56 Completed build in 07m 20s on Sun, 8 Dec, 01:56 PM Test Summary: 339 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39265
-
Alexander Schnitzler uploaded patch set 2 12/08/19, 14:04
-
TYPO3com voted on patch set 2 V -1 12/08/19, 14:12 Completed build in 07m 25s on Sun, 8 Dec, 02:12 PM Test Summary: 339 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39266
-
Alexander Schnitzler uploaded patch set 3 12/08/19, 14:51
-
TYPO3com voted on patch set 3 V -1 12/08/19, 15:00 Completed build in 09m 53s on Sun, 8 Dec, 03:00 PM Test Summary: 126 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39270
-
Alexander Schnitzler uploaded patch set 4 12/08/19, 15:21
-
TYPO3com voted on patch set 4 V -1 12/08/19, 15:29 Completed build in 07m 58s on Sun, 8 Dec, 03:29 PM Test Summary: 126 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39271
-
Alexander Schnitzler rebased onto patch set 5 01/12/20, 12:27
-
Alexander Schnitzler wrote 01/12/20, 12:28
Topic set to extbase -
Alexander Schnitzler wrote 01/12/20, 12:29
Hashtag added: PSR-7 -
TYPO3com voted on patch set 5 V -1 01/12/20, 12:47 Completed build in 16m 27s on Sun, 12 Jan, 12:47 PM Test Summary: 21 of 58112 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39808
-
TYPO3com commented on patch set 5 01/12/20, 15:21 Completed build in 3h 07m 10s on Sun, 12 Jan, 03:21 PM Test Summary: 21 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39808
-
Alexander Schnitzler uploaded patch set 6 12/05/20, 15:36
-
Alexander Schnitzler commented on patch set 6 12/05/20, 15:40
I spent some time on this patch again and I found that it's very hard to switch from a mutable to an immutable object in one patch set because there would be so many changes, nobody would review. Therefore my new approach is to make the request PSR-7 compatible in terms of using the ServerRequestInterface. We can then make the object immutable step by step by replacing the setter methods with those with-methods that clone the object. -
TYPO3com voted on patch set 6 V -1 12/05/20, 16:43 Completed build in 1h 07m 14s on Sat, 5 Dec, 04:43 PM Test Summary: 807 of 25082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7833
-
Alexander Schnitzler uploaded patch set 7 12/07/20, 09:10
-
TYPO3com voted on patch set 7 V -1 12/07/20, 09:21 Completed build in 10m 14s on Mon, 7 Dec, 09:21 AM Test Summary: 692 of 32642 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7891
-
Benni Mack uploaded patch set 8 04/13/21, 11:21
-
TYPO3com voted on patch set 8 V -1 04/13/21, 11:30 Completed build in 08m 14s on Tue, 13 Apr, 11:30 AM Test Summary: 673 of 32281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10640
-
core-ci voted on patch set 8 V -1 04/13/21, 11:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2223
-
Benni Mack rebased onto patch set 9 04/27/21, 21:36
-
core-ci voted on patch set 9 V -1 04/27/21, 21:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10799
-
Benni Mack uploaded patch set 10 06/12/21, 21:19
-
core-ci voted on patch set 10 V -1 06/12/21, 21:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12349
-
Christian Kuhn commented on patch set 10 06/28/21, 08:42
Thx for first steps in this direction. That patch helped to see how the different options will end up. We'll use the approach from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69545 So I'll abandon the patch. -
Christian Kuhn abandoned the change 06/28/21, 08:42