Review main Merged

62580[TASK] Introduce functional test for RequestBuilder

Alexander Schnitzler CR +2 V +2 Expert +720 −829 updated 12/18/19, 13:00

Commit message

The now introduced functional tests are a replacement
for the unit tests which were only possible by mocking
the hell out of the RequestBuilder.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1420

  1. Alexander Schnitzler uploaded patch set 1 12/08/19, 17:17

  2. Alexander Schnitzler wrote 12/08/19, 17:18

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 12/08/19, 17:25 Completed build in 07m 28s on Sun, 8 Dec, 05:25 PM Test Summary: 58669 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39272

  4. TYPO3com voted on patch set 1 V +1 12/08/19, 17:56 Completed build in 45m 51s on Sun, 8 Dec, 05:56 PM Test Summary: 68759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39272

  5. Alexander Schnitzler uploaded patch set 2 12/08/19, 18:36

  6. TYPO3com voted on patch set 2 V +1 12/08/19, 18:45 Completed build in 08m 51s on Sun, 8 Dec, 06:45 PM Test Summary: 68587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39273

  7. Alexander Schnitzler wrote 12/09/19, 08:51

    Hashtag added: tests
  8. Michael Telgkamp commented on patch set 2 12/11/19, 13:51

    Just a comment on the commit message, did not look into the code, yet.
    There seems to be some word missing in the description. Did you mean "The commit introduces functional tests. These are replacements for the unit tests which were only..."?
  9. Alexander Schnitzler commented on patch set 2 12/11/19, 14:21

    Reply

    Ah, no. The sentence should be: > he now introduces functional tests are a replacement ... I was quite tired when pushing that.
  10. Michael Telgkamp commented on patch set 2 12/11/19, 14:23

    Reply

    Then I would write > The now introduced ...
  11. Alexander Schnitzler commented on patch set 2 12/11/19, 14:26

    Reply

    Yes, of course. I don't know why but I seem to accidentally hit the s quite often when I intend to hit the d. ^^ > The now introduced functional tests are a replacement ...
  12. Georg Ringer voted on patch set 2 V +1 CR +1 12/12/19, 04:06

  13. Michael Telgkamp uploaded patch set 3 12/12/19, 07:17

  14. Michael Telgkamp commented on patch set 3 V +1 CR +1 12/12/19, 07:27

    Reply

    Done
  15. TYPO3com voted on patch set 3 V -1 12/12/19, 07:43 Completed build in 26m 02s on Thu, 12 Dec, 07:43 AM Test Summary: 5855 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39351

  16. TYPO3com commented on patch set 3 12/12/19, 08:57 Completed build in 2h 05m 38s on Thu, 12 Dec, 08:57 AM Test Summary: 68313 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39351

  17. TYPO3com voted on patch set 3 V +1 12/12/19, 09:07 Completed build in 3h 55m 11s on Thu, 12 Dec, 09:07 AM Test Summary: 68573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39351

  18. Daniel Goerz voted on patch set 3 V +1 12/15/19, 11:52

  19. Anja Leichsenring voted on patch set 3 V +2 CR +2 12/18/19, 12:59

  20. Anja Leichsenring merged patch set 4 12/18/19, 13:00