Review main Merged

62581[TASK] Exclude StringClassNameToClassConstantRector in rector.yml

Alexander Schnitzler CR +2 V +2 Easy +3 −9 updated 12/10/19, 12:14

Commit message

As the StringClassNameToClassConstantRector would convert
string class names that are deliberately defined as string,
this rector has been disabled.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1015

  1. Alexander Schnitzler uploaded patch set 1 12/09/19, 10:15

  2. Alexander Schnitzler updated the commit message in patch set 2 12/09/19, 10:15

  3. Alexander Schnitzler rebased onto patch set 3 12/09/19, 10:16

  4. TYPO3com voted on patch set 1 V +1 12/09/19, 10:27 Completed build in 11m 45s on Mon, 9 Dec, 10:27 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39277

  5. TYPO3com voted on patch set 2 V -1 12/09/19, 10:31 Completed build in 14m 17s on Mon, 9 Dec, 10:31 AM Test Summary: 68698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39278

  6. TYPO3com voted on patch set 3 V +1 12/09/19, 10:34 Completed build in 17m 28s on Mon, 9 Dec, 10:34 AM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39279

  7. Alexander Schnitzler wrote 12/10/19, 07:09

    Topic set to rector
  8. Andreas Kienast uploaded patch set 4 12/10/19, 09:02

  9. TYPO3com voted on patch set 4 V -1 12/10/19, 09:26 Completed build in 24m 35s on Tue, 10 Dec, 09:26 AM Test Summary: 58101 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39298

  10. TYPO3com voted on patch set 4 V +1 12/10/19, 09:45 Completed build in 1h 08m 01s on Tue, 10 Dec, 09:45 AM Test Summary: 68707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39298

  11. Andreas Kienast voted on patch set 4 CR +1 12/10/19, 10:55

  12. Oliver Klee voted on patch set 4 CR +1 12/10/19, 11:37

  13. Andreas Kienast voted on patch set 4 V +1 12/10/19, 11:53

  14. Georg Ringer voted on patch set 4 V +2 CR +2 12/10/19, 12:14

  15. Georg Ringer merged patch set 5 12/10/19, 12:14