Review main Merged

62583[TASK] Allow rector to process tests

Alexander Schnitzler CR +2 V +2 Normal +39 −13 updated 12/10/19, 08:55

Commit message

In order to let rector process tests, the autoloading
of all processed classes needs to be intact.

In TYPO3 there were a bunch of classes whose namespace
were a bit wrong according to PSR-4 and there were some
class that didn't fit the PSR-4 standard at all.

Classes that could easily be fixed have been fixed.
All others have either been registered via a class map
in composer.json or they have been excluded from the
processing of rector.

This change does not apply rector rules to tests,
it only enables rector to operate on tests due to
fixed autoloading.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 711

  1. Alexander Schnitzler uploaded patch set 1 12/09/19, 15:37

  2. TYPO3com voted on patch set 1 V -1 12/09/19, 15:44 Completed build in 07m 22s on Mon, 9 Dec, 03:44 PM Test Summary: 18 of 69158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39287

  3. Alexander Schnitzler uploaded patch set 2 12/09/19, 15:49

  4. TYPO3com voted on patch set 2 V -1 12/09/19, 15:56 Completed build in 07m 20s on Mon, 9 Dec, 03:56 PM Test Summary: 68476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39288

  5. TYPO3com voted on patch set 2 V +1 12/09/19, 16:02 Completed build in 20m 31s on Mon, 9 Dec, 04:02 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39288

  6. Alexander Schnitzler updated the commit message in patch set 3 12/09/19, 16:02

  7. TYPO3com voted on patch set 3 V +1 12/09/19, 16:10 Completed build in 07m 38s on Mon, 9 Dec, 04:10 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39289

  8. Alexander Schnitzler wrote 12/10/19, 07:09

    Topic set to rector
  9. Georg Ringer voted on patch set 3 V +1 CR +1 12/10/19, 07:17

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 12/10/19, 08:54

  11. Andreas Kienast merged patch set 4 12/10/19, 08:55