Review TYPO3_8-7 Merged

62589[BUGFIX] Raise platform settings for tarball distributions

Benni Mack CR +2 V +2 Easy +3 −3 updated 12/10/19, 11:38

Commit message

In order to use the final LTS distributions from Symfony for
our latest stable, we need to set proper platform requirements
for the root composer.json.

Our packages rely on the settings so the base package
can properly raise dependencies.

Symfony has the requirements due to other PHP bugs (fixed
very early already), however using the tarballs in
7.2.0 / 7.0.0 would still work, as the symfony changes
only fix issues we dont rely on.

v10: 7.2.5
v9: 7.2.5
v8: 7.0.8

Used composer commands:

  composer config platform.php 7.0.8
  composer update --lock

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 12/10/19, 11:14

  2. Oliver Hader voted on patch set 1 CR +1 12/10/19, 11:14

  3. TYPO3com voted on patch set 1 V +1 12/10/19, 11:24 Completed build in 09m 46s on Tue, 10 Dec, 11:24 AM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3752

  4. Oliver Klee voted on patch set 1 CR +1 12/10/19, 11:36

  5. Oliver Hader voted on patch set 1 V +2 CR +2 12/10/19, 11:37

  6. Oliver Hader merged patch set 2 12/10/19, 11:38