62592[TASK] Apply rector set php70
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 25
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php1+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Configuration/Richtext.php+1 −1
- typo3/sysext/core/Classes/Context/LanguageAspect.php+1 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Classes/Mail/FileSpool.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Mirrors.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+4 −4
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/AjaxWidgetContextHolder.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Hooks/TreelistCacheUpdateHooks.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php+2 −2
Show 5 more files
Review log 1013
-
Alexander Schnitzler uploaded patch set 1 12/10/19, 13:28
-
TYPO3com voted on patch set 1 V -1 12/10/19, 13:28 Completed build in 07s on Tue, 10 Dec, 01:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39306
-
Alexander Schnitzler wrote 12/10/19, 13:44
Topic set to rector -
Andreas Kienast rebased onto patch set 2 12/18/19, 13:31
-
TYPO3com voted on patch set 2 V -1 12/18/19, 13:40 Completed build in 09m 07s on Wed, 18 Dec, 01:40 PM Test Summary: 68844 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39504
-
TYPO3com voted on patch set 2 V +1 12/18/19, 14:28 Completed build in 1h 06m 27s on Wed, 18 Dec, 02:28 PM Test Summary: 69126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39504
-
Alexander Schnitzler commented on patch set 2 12/19/19, 08:32
This change is ready for review. -
Andreas Kienast voted on patch set 2 CR +1 12/19/19, 08:43
-
Oliver Klee voted on patch set 2 CR +1 12/19/19, 10:09
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 12/19/19, 13:43
-
Andreas Kienast voted on patch set 2 V +2 CR +2 12/19/19, 14:00
-
Andreas Kienast merged patch set 3 12/19/19, 14:00
-
Oliver Hader commented on patch set 3 12/27/19, 20:38
SiteConfigurationController.php:360UnresolvedWhat about `bin2hex(random_bytes(16))` which looks more reliable on the majority of OS'?