Review main Merged

62592[TASK] Apply rector set php70

Alexander Schnitzler CR +2 V +2 Normal +36 −34 updated 12/27/19, 20:38

Commit message

php bin/rector process

The Rector\Php70\Rector\List_\ListSwapArrayOrderRector rector
has been disabled as this needs proper testing and a separate
patch.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1013

  1. Alexander Schnitzler uploaded patch set 1 12/10/19, 13:28

  2. TYPO3com voted on patch set 1 V -1 12/10/19, 13:28 Completed build in 07s on Tue, 10 Dec, 01:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39306

  3. Alexander Schnitzler wrote 12/10/19, 13:44

    Topic set to rector
  4. Andreas Kienast rebased onto patch set 2 12/18/19, 13:31

  5. TYPO3com voted on patch set 2 V -1 12/18/19, 13:40 Completed build in 09m 07s on Wed, 18 Dec, 01:40 PM Test Summary: 68844 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39504

  6. TYPO3com voted on patch set 2 V +1 12/18/19, 14:28 Completed build in 1h 06m 27s on Wed, 18 Dec, 02:28 PM Test Summary: 69126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39504

  7. Alexander Schnitzler commented on patch set 2 12/19/19, 08:32

    This change is ready for review.
  8. Andreas Kienast voted on patch set 2 CR +1 12/19/19, 08:43

  9. Oliver Klee voted on patch set 2 CR +1 12/19/19, 10:09

  10. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/19/19, 13:43

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 12/19/19, 14:00

  12. Andreas Kienast merged patch set 3 12/19/19, 14:00

  13. Oliver Hader commented on patch set 3 12/27/19, 20:38

    SiteConfigurationController.php:360 Unresolved

    What about `bin2hex(random_bytes(16))` which looks more reliable on the majority of OS'?