62593[BUGFIX] Send HTTP headers with PSR-7 response
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Jörg Bösche +1
-
Verified V +2 Done
- Susi Moog +2
- Tobi Kretschmann +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+11 −29
- typo3/sysext/core/Classes/Middleware/BackendUserAuthenticator.php1new+97 −0
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+8 −27
- typo3/sysext/frontend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.phpnew+73 −0
Review log 1418
-
Benni Mack uploaded patch set 1 12/10/19, 15:01
-
TYPO3com voted on patch set 1 V -1 12/10/19, 15:36 Completed build in 35m 44s on Tue, 10 Dec, 03:36 PM Test Summary: 68456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39307
-
Benni Mack updated the commit message in patch set 2 12/10/19, 16:03
-
TYPO3com voted on patch set 2 V +1 12/10/19, 16:48 Completed build in 45m 00s on Tue, 10 Dec, 04:48 PM Test Summary: 68715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39309
-
Susi Moog commented on patch set 2 12/15/19, 15:17
-
Susi Moog commented on patch set 2 CR -1 12/15/19, 15:35
can we get rid of the duplication? now the headers are applied twice (once with header once with response) - maybe only send the headers in FrontendUserAuth instead of the Abstract? -
Benni Mack commented on patch set 2 12/16/19, 10:33
> Patch Set 2: Code-Review-1 > > can we get rid of the duplication? now the headers are applied twice (once with header once with response) - maybe only send the headers in FrontendUserAuth instead of the Abstract? FrontendUserAuth does not send the headers at all anymore - this is done in TSFE, only BackendUserAuth (via Abstract) does this. My other patch actually removed this change, but this would be very breaking. Currently, I just wanted to make sure that the PSR-7 Response object reflects the same headers as before (I'm still working on the Set-Cookie part, which will be tackled separately). -
Susi Moog commented on patch set 2 12/16/19, 12:01
> Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > can we get rid of the duplication? now the headers are applied twice (once with header once with response) - maybe only send the headers in FrontendUserAuth instead of the Abstract? > > FrontendUserAuth does not send the headers at all anymore - this is done in TSFE, only BackendUserAuth (via Abstract) does this. My other patch actually removed this change, but this would be very breaking. Currently, I just wanted to make sure that the PSR-7 Response object reflects the same headers as before (I'm still working on the Set-Cookie part, which will be tackled separately). (FrontendUserAuth would send the headers if the public property was set to true from the outside for any reason). It just kind of "smells funny" to send the headers twice now. -
Benni Mack uploaded patch set 3 12/23/19, 22:22
-
Benni Mack commented on patch set 3 12/23/19, 22:23
Set the change to master-only, and removed the <IE8 support. -
TYPO3com voted on patch set 3 V +1 12/23/19, 22:33 Completed build in 10m 26s on Mon, 23 Dec, 10:33 PM Test Summary: 69133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39561
-
Benni Mack uploaded patch set 4 01/14/20, 13:31
-
TYPO3com voted on patch set 4 V +1 01/14/20, 13:41 Completed build in 09m 41s on Tue, 14 Jan, 01:41 PM Test Summary: 69572 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39902
-
Jörg Bösche voted on patch set 4 CR +1 01/15/20, 15:07
-
Sascha Rademacher voted on patch set 4 CR +1 01/16/20, 08:51
-
Tobi Kretschmann voted on patch set 4 V +1 CR +1 01/16/20, 09:20
-
Susi Moog voted on patch set 4 V +2 CR +2 01/16/20, 09:24
-
Susi Moog merged patch set 5 01/16/20, 09:24
BackendUserAuthenticator.php:98Unresolved