Review main Merged

62594[TASK] Remove ampersands from doc block params

Alexander Schnitzler CR +2 V +2 Normal +41 −41 updated 12/11/19, 08:36

Commit message

As a prepatory work for a better static code analysis
all ampersands have been removed from doc block params.

The doc block must not reflect whether a variable is
passed by value or reference.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 910

  1. Alexander Schnitzler uploaded patch set 1 12/10/19, 16:16

  2. Oliver Klee voted on patch set 1 CR +1 12/10/19, 16:30

  3. TYPO3com voted on patch set 1 V +1 12/10/19, 16:46 Completed build in 30m 46s on Tue, 10 Dec, 04:46 PM Test Summary: 68706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39310

  4. Oli Bartsch commented on patch set 1 V +1 CR +1 12/10/19, 19:54

    Rfc822AddressesParser.php:370

    There seems to be a wrong char. Should this also be tackled in this patch?
  5. Alexander Schnitzler commented on patch set 1 12/10/19, 20:20

    Rfc822AddressesParser.php:370 Reply

    That's not necessary, we will use rector and other tools to correct wrong types in the future. This patch is a preparation to make this automatic code change possible.
  6. Oli Bartsch commented on patch set 1 12/11/19, 07:03

    Rfc822AddressesParser.php:370 Reply

    Ack
  7. Mathias Brodala voted on patch set 1 V +1 CR +1 12/11/19, 07:29

  8. Björn Jacob voted on patch set 1 V +1 CR +1 12/11/19, 08:34

  9. Andreas Kienast voted on patch set 1 V +2 CR +2 12/11/19, 08:36

  10. Andreas Kienast merged patch set 2 12/11/19, 08:36