Review main Merged

62595[FEATURE] Separate system from 3rd-party extensions

Michael Schams CR +2 V +2 Normal +136 −14 updated 02/10/20, 08:00

Commit message

This feature separates system extensions from 3rd-party extensions
visually.

The extension list shown in the Extension Manager can now be filtered
by certain extension types (system and 3rd-party extensions).

The selected filter is saved to the backend user configuration.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Riccardo De Contardi +1
    • Benni Mack +1

Issues 1

Files 5

Review log 1316

  1. Michael Schams uploaded patch set 1 12/11/19, 05:53

  2. TYPO3com voted on patch set 1 V -1 12/11/19, 05:54 Completed build in 17s on Wed, 11 Dec, 05:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39321

  3. Oli Bartsch uploaded patch set 2 12/14/19, 01:12

  4. Oli Bartsch uploaded patch set 3 12/14/19, 01:20

  5. TYPO3com voted on patch set 2 V -1 12/14/19, 01:21 Completed build in 08m 23s on Sat, 14 Dec, 01:21 AM Test Summary: 86 of 69167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39419

  6. TYPO3com voted on patch set 3 V -1 12/14/19, 01:28 Completed build in 07m 50s on Sat, 14 Dec, 01:28 AM Test Summary: 86 of 69157 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39420

  7. Andreas Kienast commented on patch set 3 12/14/19, 13:55

    ListController.php:338 Unresolved

    We may use TYPO3\CMS\Backend\Configuration\BackendUserConfiguration here

    ListUtility.php:122 Unresolved

    Do we really need to distinguish an empty filter from "All"?
  8. Michael Schams commented on patch set 3 12/15/19, 00:22

    - When a BE user accesses the EM the first time (without any state stored in the UC yet), none of the buttons are highlighted (selected). Given that the complete list is shown by default, button "All" should be selected. - The three filter buttons are very close to the search input field. I wonder if users could be confused, because you could expect that these actions are related to the search.
  9. Michael Schams marked it work in progress 12/15/19, 00:22

  10. Andreas Kienast commented on patch set 3 12/15/19, 06:32

    > Patch Set 3: > > - When a BE user accesses the EM the first time (without any state stored in the UC yet), none of the buttons are highlighted (selected). Given that the complete list is shown by default, button "All" should be selected. Let me rephrase my point, I think I didn't express myself in a clear manner. I agree there is a technical reason right now do check for an empty string and for "All", but for the behavior there is no difference. If you click the button / select the value labeled "All", why don't we send an empty string as well? This way you won't need any additional checks to achieve the same behavior.
  11. Michael Schams uploaded patch set 4 02/09/20, 08:56

  12. Michael Schams commented on patch set 4 02/09/20, 10:06

    Andreas: understood. Patch set 4 takes this into account and moves the buttons to the right. WIP-status removed.
  13. Riccardo De Contardi voted on patch set 4 V +1 02/09/20, 10:10

  14. Benni Mack voted on patch set 4 V +1 CR +1 02/10/20, 07:58

  15. Georg Ringer voted on patch set 4 V +2 CR +2 02/10/20, 08:00

  16. Georg Ringer merged patch set 5 02/10/20, 08:00