Review main Abandoned

62598[TASK] Rename none existent user config key

Jan Stockfisch CR 0 V 0 Normal +70 −10 updated 01/30/20, 11:41

Commit message

The naming from the pibase plugin for the exposeNoneExistentUser flash
message is now deprecated in the extbase context and has been changed
to: `exposeNoneExistentUserInForgotPasswordDialog`. However a fallback
is still provided.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1624

  1. Jan Stockfisch uploaded patch set 1 12/11/19, 09:32

  2. Jan Stockfisch marked it work in progress 12/11/19, 09:32

  3. TYPO3com voted on patch set 1 V +1 12/11/19, 09:44 Completed build in 12m 24s on Wed, 11 Dec, 09:44 AM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39327

  4. Jan Stockfisch uploaded patch set 2 12/11/19, 09:53

  5. TYPO3com voted on patch set 2 V -1 12/11/19, 10:33 Completed build in 40m 49s on Wed, 11 Dec, 10:33 AM Test Summary: 10 of 69165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39329

  6. Jan Stockfisch uploaded patch set 3 12/11/19, 13:58

  7. Jan Stockfisch uploaded patch set 4 12/11/19, 14:00

  8. Jan Stockfisch updated the commit message in patch set 5 12/11/19, 14:02

  9. Jan Stockfisch commented on patch set 5 12/11/19, 14:02

    This change is ready for review.
  10. Jan Stockfisch rebased onto patch set 6 12/11/19, 14:04

  11. Jan Stockfisch wrote 12/11/19, 14:06

    Topic set to felogin
  12. TYPO3com voted on patch set 3 V +1 12/11/19, 14:08 Completed build in 09m 47s on Wed, 11 Dec, 02:08 PM Test Summary: 68710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39338

  13. Jan Stockfisch commented on patch set 6 12/11/19, 14:16

    Not sure if we would need an UpgradeWizard for the database related typoscript records. Should I provide one?
  14. TYPO3com voted on patch set 5 V +1 12/11/19, 14:29 Completed build in 25m 20s on Wed, 11 Dec, 02:29 PM Test Summary: 68707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39340

  15. TYPO3com voted on patch set 4 V +1 12/11/19, 14:39 Completed build in 38m 49s on Wed, 11 Dec, 02:39 PM Test Summary: 68716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39339

  16. TYPO3com voted on patch set 6 V +1 12/11/19, 14:42 Completed build in 38m 19s on Wed, 11 Dec, 02:42 PM Test Summary: 68713 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39341

  17. Jan Stockfisch rebased onto patch set 7 12/16/19, 06:43

  18. TYPO3com voted on patch set 7 V +1 12/16/19, 06:56 Completed build in 12m 25s on Mon, 16 Dec, 06:56 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39442

  19. Jan Stockfisch rebased onto patch set 8 01/07/20, 15:32

  20. TYPO3com voted on patch set 8 V +1 01/07/20, 15:45 Completed build in 11m 53s on Tue, 7 Jan, 03:45 PM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39741

  21. Benni Mack commented on patch set 8 01/09/20, 14:13

    Can you give me a reason for this change? "NonexistentUser" - what's exactly wrong with that?
  22. Steffen Frese commented on patch set 8 CR -1 01/15/20, 13:15

    IMO "nonexistent user" is correct and "none existent user" is incorrect.
  23. Michael Schams commented on patch set 8 V -1 01/20/20, 01:27

    It's either "nonexistent" or "non-existent". https://dictionary.cambridge.org/dictionary/english/non-existent https://dictionary.cambridge.org/dictionary/english/nonexistent "Non-existent" (with hyphen) can be used in British English (BE) and American English (AE). "Nonexistent" (one word, without hyphen) is American English. In general English, "nonexistent" is usually used: https://books.google.com/ngrams/graph?content=non-existent%2Cnonexistent&year_start=1970&year_end=2005 The English native speakers around me can't agree on a term, but confirmed that it's definitely not "none existent" :-)
  24. Jan Stockfisch abandoned the change 01/30/20, 11:41

    I can't remember what exactly was the reason was behind this one. I'd guess to go for the british way, not the US one. But TBH it should stay this way. Maybe @Georg Ringer can recall the exact thought behind it.